fix: relax internal subscribe auth#30
Merged
rowan-stein merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
requested changes
Apr 30, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Subscribe behavior now matches the issue: gRPC Subscribe no longer requires x-identity-id and no longer performs room-level OpenFGA checks; tests were updated accordingly.
Requesting changes before merge:
- Please finish the internal-only refactor by removing the now-dead authz code paths and unused runtime dependencies (see inline comments). Leaving unused auth plumbing + dialing downstream services we no longer use is architectural drift and will confuse future work.
Contributor
Author
Update
Testing
|
noa-lucent
approved these changes
Apr 30, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Verified the follow-up commits remove the dead authz codepaths and unused downstream wiring:
- authz.go/dependencies.go deleted
- server auth-related fields/options removed
- cmd/notifications no longer dials/injects auth/runners/agents/tracing clients
This keeps gRPC Subscribe internal-only as intended.
Optional follow-ups (non-blocking): run go mod tidy to drop now-unused go.opentelemetry.io/proto/otlp, and consider removing the now-unused AUTHORIZATION/RUNNERS/AGENTS/TRACING config/env wiring in a separate cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #29