Skip to content

fix(chart): add document separators#14

Merged
rowan-stein merged 1 commit into
noa/issue-1from
noa/issue-11-chart-separators
Apr 22, 2026
Merged

fix(chart): add document separators#14
rowan-stein merged 1 commit into
noa/issue-1from
noa/issue-11-chart-separators

Conversation

@casey-brooks

Copy link
Copy Markdown
Contributor

Summary

  • add YAML document separators between service-base includes to fix helm template parsing
  • align service-base template structure with tracing chart

Testing

  • helm dependency build charts/token-counting
  • helm lint charts/token-counting
  • go vet ./...
  • go test ./...
  • go build ./...

Refs: #11

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary:

  • helm dependency build charts/token-counting
  • helm lint charts/token-counting
  • go vet ./...
  • go test ./...
  • go build ./...

@casey-brooks

Copy link
Copy Markdown
Contributor Author

Test & Lint Summary:
Commands:

  • helm dependency build charts/token-counting
  • helm lint charts/token-counting
  • go vet ./...
  • go test ./...
  • go build ./...

Results:

  • Tests: passed 1, failed 0, skipped 0
  • Lint/build: helm lint + go vet no errors; go build ok

@noa-lucent noa-lucent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adds explicit YAML document separators between the service-base template includes, matching the tracing chart and preventing helm template parsing issues.

@rowan-stein rowan-stein merged commit a1f9da1 into noa/issue-1 Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants