Conversation
Update dependent node types and resulting errors Ignore node_modules this is causing high cpu / failures in zendesk extension
tim-field
commented
Apr 2, 2026
| // would probably need to be more complex. | ||
| build.onLoad({ filter: /.*/, namespace: 'http-url' }, async args => { | ||
| let contents: Buffer; | ||
| let contents: Uint8Array; |
Contributor
Author
There was a problem hiding this comment.
Appeasing TS after Node types upgrade ( which is required for chokidar update )
tim-field
commented
Apr 2, 2026
| async set(url: string, data: Buffer) { | ||
| const filePath = path.join(this.location, this.hash(url)); | ||
| return fs.writeFile(filePath, data); | ||
| return fs.writeFile(filePath, new Uint8Array(data)); |
Contributor
Author
There was a problem hiding this comment.
Appease TS, Buffer can't be passed to writeFile
tim-field
commented
Apr 2, 2026
| chokidar | ||
| .watch('.', { ignoreInitial: true, ignored: '.git' }) | ||
| .on('all', async (event, changedPath) => { | ||
| .watch('.', { ignoreInitial: true, ignored: ['.git', 'node_modules'] }) |
Contributor
Author
There was a problem hiding this comment.
ignore node_modues
This is a breaking change, hence the version bump. But is required to watch the zendesk extension without using all your CPU as it stands.
tim-field
changed the title
jemmyw
approved these changes
Apr 2, 2026
tim-field
deleted the
DEVELOP-2300-4-fix-aha-cli-failing-when-watching-zendesk-extension
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extension:watchwill now ignore node_modules. Bumped package version as this is technically a breaking change, butextension:watchis broken at least in the zendesk extension without this.Note its possible to test this locally like so
yarn packnpx --yes --package /{path-to-built.tgz}.tgz aha extension:watch