DEVELOP-780 Add dashboard panel contribution#16
Merged
percyhanna merged 2 commits intomainfrom Jun 18, 2021
Merged
Conversation
jemmyw
force-pushed
the
DEVELOP-780-panels
branch
from
1a09d03 to
717b475
Compare
jemmyw
force-pushed
the
DEVELOP-780-panels
branch
from
717b475 to
b633ac9
Compare
jemmyw
commented
Jun 17, 2021
| "target": "ES6" | ||
| } | ||
| }, | ||
| "include": [".aha-cache/aha.d.ts", "src"] |
Collaborator
Author
There was a problem hiding this comment.
Update as per the types being downloaded change coming in the client
jemmyw
commented
Jun 17, 2021
| @@ -1,20 +0,0 @@ | |||
| import { AuthProvider } from "@aha-app/aha-develop-react"; | |||
Collaborator
Author
There was a problem hiding this comment.
renamed to src/views/attribute.js
jemmyw
commented
Jun 17, 2021
| @@ -1,16 +1,17 @@ | |||
| import { AuthProvider } from "@aha-app/aha-develop-react"; | |||
Collaborator
Author
There was a problem hiding this comment.
git has picked this up as a file rename, but actually this file moved to src/views/prsPage.js and the ExtensionRoot is an extraction from all the react entry points.
percyhanna
reviewed
Jun 17, 2021
Contributor
percyhanna
left a comment
percyhanna
left a comment
There was a problem hiding this comment.
This looks great. Marking for security review as well.
cornu-ammonis
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets you create a pull requests panel on a dashboard using any search query as per https://docs.github.com/en/github/searching-for-information-on-github/searching-on-github/searching-issues-and-pull-requests