Skip to content

Add a full page screen#2

Merged
k1w1 merged 2 commits intomasterfrom
full_page
Feb 3, 2021
Merged

Add a full page screen#2
k1w1 merged 2 commits intomasterfrom
full_page

Conversation

@jemmyw
Copy link
Collaborator

@jemmyw jemmyw commented Jan 29, 2021

No description provided.

package.json Outdated
"ahaExtension": {
"contributes": {
"views": {
"attributes": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still be "views", and there should be a "host" sub-key like:

"views": {
  "links": {
      "title": "Github links",
      "host": "attributes"
  },
  "prs": {
      "title": "Full page view of PRs",
      "host": "page"
  },
}

const { search } = await api(`
{
search(query:"in:title in:body type:pr \\"${record.referenceNum}\\" repo:\\"k1w1/racer_experiment\\"", type: ISSUE, first:20 ) {
search(query:"in:title in:body type:pr \\"${record.referenceNum}\\" repo:\\"jemmyw/small-mammals\\"", type: ISSUE, first:20 ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need a good way to specify the relevant repos.

@k1w1 k1w1 merged commit e99051f into master Feb 3, 2021
@k1w1 k1w1 deleted the full_page branch February 3, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants