DEVELOP-1470: Status changes to PRs are no longer updating extension fields#29
Merged
percyhanna merged 1 commit intomainfrom Jul 28, 2022
Conversation
… when processing a webhook the extension would no longer update the extension fields with the new PR information if the record was already linked
percyhanna
deleted the
DEVELOP-1470-status-changes-prs-no-longer-updating-extension-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made to support status events introduced a regression whereby when processing a webhook the extension would no longer update the extension fields with the new PR information if the record was already linked.
Looking at the code, I believe the mistake was made because the naming of the function that performs the update was unclear, so I've renamed it and fixed the usage with added comment and some debug logging.