DEVELOP-471-1 security review changes#9
Merged
cornu-ammonis merged 3 commits intomasterfrom Apr 27, 2021
Merged
Conversation
jemmyw
approved these changes
Apr 27, 2021
jemmyw
approved these changes
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aha! requirement
we should be mindful of links as an xss vector. a user could update the extension field values for pr url etc to be "javascript:alert(1)" etc which will trigger xss on click for a standard react <a tag. in chrome this doesnt work when the <a tag is target="_blank" but in safari it does work. I've created https://big.aha.io/features/DEVOPS-626 to track a longer term solution to this.