fix: NTP packet correctness and UDP socket lifecycle#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zero-initialize NTP packet buffer:
byte packetBuffer[NTP_PACKET_SIZE] = {0}and explicit header-byte assignments.Close UDP socket on every exit path:
mUdp->begin()was never closed, causingbegin()to fail when a second client was created on the same UDP object.mUdp->stop()is now called before everyreturnand after the successful response read.Remove
staticfrom socket initializer:static int udpInitedwas evaluated exactly once per program lifetime.begin().staticmakesgetServerTime()fully self-contained: it opens a socket, uses it, and closes it on every call.123toNTP_REQUEST_PORT(1123).Adds
test_basic_sync()andtest_client_reuse()toexamples/TestNodeMCU/TestNodeMCU.ino.Closes PRs #6 & #7