Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to restore Java 17 compatibility for matchbox-engine (and related modules) so the produced artifacts can be used on platforms limited to JRE 17 (per issue #510).
Changes:
- Removes the root POM’s Java 21 compiler release setting and compiler-plugin configuration.
- Sets Java compilation target to 17 in
matchbox-engineandmatchbox-servermodule POMs by addingmaven-compiler-pluginconfiguration. - Updates a
matchbox-enginetest to avoid Java 21’sList.getFirst()API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Removes the parent-level maven.compiler.release and parent compiler-plugin configuration. |
| matchbox-server/pom.xml | Sets module compilation target to Java 17 and adds compiler-plugin configuration. |
| matchbox-engine/pom.xml | Sets module compilation target to Java 17 and adds compiler-plugin configuration. |
| matchbox-engine/src/test/java/ch/ahdis/matchbox/engine/tests/CdaToFhirTransformTests.java | Replaces Java 21 List.getFirst() usage with Java 17-compatible indexing. |
Comments suppressed due to low confidence (1)
pom.xml:44
- The compiler-plugin configuration (release/encoding/annotationProcessorPaths) is now duplicated across submodules. To keep Java target configuration consistent and avoid future modules accidentally compiling for the build JDK default, consider restoring a parent-level
maven-compiler-pluginconfiguration and setting a defaultmaven.compiler.release(likely 17) in the rootpom.xml, letting submodules override only if necessary.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<fhir.core.version>6.9.4</fhir.core.version>
<hapi.fhir.version>8.8.0</hapi.fhir.version>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
77027d0 to
fde6d50
Compare
fde6d50 to
c7ff02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510