Skip to content

chore(engine): re-add support for JRE 17#514

Open
qligier wants to merge 1 commit intomainfrom
feat/engine-jre17
Open

chore(engine): re-add support for JRE 17#514
qligier wants to merge 1 commit intomainfrom
feat/engine-jre17

Conversation

@qligier
Copy link
Copy Markdown
Member

@qligier qligier commented Apr 20, 2026

Fixes #510

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to restore Java 17 compatibility for matchbox-engine (and related modules) so the produced artifacts can be used on platforms limited to JRE 17 (per issue #510).

Changes:

  • Removes the root POM’s Java 21 compiler release setting and compiler-plugin configuration.
  • Sets Java compilation target to 17 in matchbox-engine and matchbox-server module POMs by adding maven-compiler-plugin configuration.
  • Updates a matchbox-engine test to avoid Java 21’s List.getFirst() API.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
pom.xml Removes the parent-level maven.compiler.release and parent compiler-plugin configuration.
matchbox-server/pom.xml Sets module compilation target to Java 17 and adds compiler-plugin configuration.
matchbox-engine/pom.xml Sets module compilation target to Java 17 and adds compiler-plugin configuration.
matchbox-engine/src/test/java/ch/ahdis/matchbox/engine/tests/CdaToFhirTransformTests.java Replaces Java 21 List.getFirst() usage with Java 17-compatible indexing.
Comments suppressed due to low confidence (1)

pom.xml:44

  • The compiler-plugin configuration (release/encoding/annotationProcessorPaths) is now duplicated across submodules. To keep Java target configuration consistent and avoid future modules accidentally compiling for the build JDK default, consider restoring a parent-level maven-compiler-plugin configuration and setting a default maven.compiler.release (likely 17) in the root pom.xml, letting submodules override only if necessary.
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

        <fhir.core.version>6.9.4</fhir.core.version>
        <hapi.fhir.version>8.8.0</hapi.fhir.version>


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread matchbox-server/pom.xml Outdated
@qligier qligier force-pushed the feat/engine-jre17 branch 2 times, most recently from 77027d0 to fde6d50 Compare April 20, 2026 18:16
@qligier qligier force-pushed the feat/engine-jre17 branch from fde6d50 to c7ff02c Compare April 21, 2026 08:19
@qligier qligier requested a review from oliveregger April 21, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Java 17 compatibility for matchbox-engine — is Java 21 a hard requirement?

2 participants