fix: force canonical name for builtin std module name#633
Merged
aherrmann merged 2 commits intoaherrmann:mainfrom Apr 24, 2026
Merged
fix: force canonical name for builtin std module name#633aherrmann merged 2 commits intoaherrmann:mainfrom
aherrmann merged 2 commits intoaherrmann:mainfrom
Conversation
There is a hardcoded rule in handling of --dep in zig that doesn't allow doing anything else but --dep=std=std
aherrmann
reviewed
Apr 24, 2026
Owner
aherrmann
left a comment
There was a problem hiding this comment.
Is ctx.label.name == "std" the right condition? Shouldn't this trigger on ctx.attr.import_name == "std"? Otherwise this would falsely trigger on the following:
# //foo:BUILD.bazel
zig_library(
name = "std",
import_name = "foo_std",
...
)
Contributor
Author
|
Indeed ! I'll check import_name if it's not None and fallback on name. |
Contributor
Author
|
Amended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small one but required to build Zig with
rules_ziginstead since we have to do azig_libraryfor std.There is a hardcoded rule in the handling of --dep in zig that doesn't allow doing anything else but --dep=std=std.
https://codeberg.org/ziglang/zig/src/commit/5cc281e7232b9f1bc5f4d732e4a37fb5df02f780/src/main.zig#L1091-L1097