Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of social sharing buttons “above content” not appearing on pages. #2809

Closed
pegazee opened this issue Jan 14, 2019 · 3 comments
Closed

Position of social sharing buttons “above content” not appearing on pages. #2809

pegazee opened this issue Jan 14, 2019 · 3 comments
Assignees
@pegazee
Labels
bug
Milestone
Wave

Comments

@pegazee
Copy link
Contributor

pegazee commented Jan 14, 2019

Link: https://wordpress.org/support/topic/social-share-button-2/

Also, I've re-created the issue on my end.
@ahmedkaludi ahmedkaludi added this to the Wave milestone Jan 15, 2019
@pegazee pegazee self-assigned this Jan 16, 2019
@pegazee pegazee added the bug label Jan 16, 2019
@pegazee pegazee modified the milestones: Wave, W15 Jan 16, 2019
pegazee added a commit that referenced this issue Jan 16, 2019
@pegazee
#2809 social sharing buttons “above content” on page
8d46770 
#2809 social sharing buttons “above content” on page added
@ajeetku
Copy link
Contributor

ajeetku commented Jan 16, 2019 •
edited

use this function to get options data ampforwp_get_setting()

pegazee added a commit that referenced this issue Jan 16, 2019
@pegazee
#2809 proper code & styling added
28f48ff 
#2809 proper code & styling added
pegazee added a commit that referenced this issue Jan 16, 2019
@pegazee
#2809 proper code
4195d4c 
#2809 proper code
@pegazee
Copy link
Contributor Author

pegazee commented Jan 16, 2019

Moving this ticket to the Approval section

pegazee added a commit that referenced this issue Jan 16, 2019
@pegazee
#2809 Added in master
487499f 
#2809 Added in master
@HANEEFRIYAZ
Copy link

Pushed in 0.9.97.25

nicholasgriffintn pushed a commit to nicholasgriffintn/accelerated-mobile-pages that referenced this issue Mar 3, 2019
Updating (#16)
6bae3dc 
* price added

* ahmedkaludi#2501 videos rendering issue in convert to wp fixed and added in master

* renamed plugin name

* ahmedkaludi#2600 title and host updated in vuukle and added in master

* ahmedkaludi#2598 icons added for SU and AMP stories and added in master

* ahmedkaludi#2686 Avoid amp params when Takeover is enabled and added in master

* ahmedkaludi#2586 View Non-AMP version fixed and added in master

* ahmedkaludi#2699 Removed because class is being removed from table and added in master

* ahmedkaludi#2586 mobile redirection condtion added

ahmedkaludi#2586 mobile redirection condtion added

* ahmedkaludi#2694 Images are stretched in convert to wp fixed and added in master

* ahmedkaludi#2562 Internal links code improvement code added in master

* ahmedkaludi#2562 It should check for both name and id added in master

* ahmedkaludi#2523 FBIA instagram sanitizer added in master

* ahmedkaludi#2706 Modification of single settings when newspaper theme activated.

* ahmedkaludi#2606 words breaking in table on mobile fixed and added in master

* ahmedkaludi#2598 Resolve, sorting issue in extension list between activated extension and non activated Extension

ahmedkaludi#2598 Resolve, sorting issue in extension list between activated extension and non activated Extension

* Changelog and version number updated

Changelog and version number updated

* ahmedkaludi#2706 More code added

* ahmedkaludi#2305 updated the repeater field and added in master

* ahmedkaludi#2471 Improvements in AMP pagebuilder points 1,2 and 3 added in master

* ahmedkaludi#2704 removed all spans and updated h1 to h2 from 404 pages and added in master

* ahmedkaludi#2709 Export option of page builder is not working fixed and added in master

* ahmedkaludi#2697 No esc_html for json example

* Revert "ahmedkaludi#2697 No esc_html for json example"

This reverts commit 59971e6.

* ahmedkaludi#2697 No translation needed for this

* ahmedkaludi#2706 Code improvement & added internal link in field description

* ahmedkaludi#2677 featured slider problem is fix in firefox in Design 3

ahmedkaludi#2677 featured slider problem is fix in firefox in Design 3

* ahmedkaludi#2677 small styling changes in the slider

ahmedkaludi#2677 small styling changes in the slider.

* ahmedkaludi#2699 deleted the unused code of tables

* Change log is updated

Change log is updated

* ahmedkaludi#2476 updated the code for getting the current url and added in master

* ahmedkaludi#2476 improved theme my login plugin function and added in master

* Tested upto 5.0 addeed

1. 40% Banner added
2. Tested upto 5.0 added
3. Pricing update as per 40% in pricing table

* Ticket number added

Ticket number added

* ahmedkaludi#2717 Changed the apostrophe to single quote to avoid errors during serialization

* Revert "ahmedkaludi#2717 Changed the apostrophe to single quote to avoid errors during serialization"

This reverts commit d2127c7.

* Version number updated

* ahmedkaludi#2672 Remove Publisher theme menu in amp and added in master

* ahmedkaludi#2657 Fatal error when no language is selected in polylang fixed and added in master

* ahmedkaludi#2725 improved code in amp-page-builder.php and added in master

* ahmedkaludi#2723 proper escaping added in dev mode and added in master

* ahmedkaludi#2717 Changed the apostrophe to single quote to avoid errors during serialization and added in master

* ahmedkaludi#2726 Remove the width because the logo takes the width from the options panel and added in master

* removed extra code ahmedkaludi#2723

removed extra code ahmedkaludi#2723

* Changelog updated

Changelog updated

* ahmedkaludi#2762 performance issues fixed

* ahmedkaludi#2761 added ampforwp_is_amp_endpoint and ampforwp_url_controller filters in master

* ahmedkaludi#2762 restricted the categories and tags to 500 and added in master

* ahmedkaludi#2735 Code improvement to make AMP to WP work better and added in master

* ahmedkaludi#2748 Image sanitizer updated and updated the vendor changelog and added in master

* ahmedkaludi#2777 Update the condition

* ahmedkaludi#2762 wp_nonce and proper prefix added in master

* ahmedkaludi#2531 Responsive Ad unit option improved and added in master

* ahmedkaludi#2763 GDPR isn't closing with convert to wp option fixed and added in master

* ahmedkaludi#2750 added proper preg replace for blockquote and added in master

* Removed banner and offer code

* Change log updated and version number updated

Change log updated and version number updated

* ahmedkaludi#2512 Proper code to make custom Post type archives work and added in master

* updated the changelog

updated the changelog

* ahmedkaludi#2785 Drop down icon appearing twice problem is fixed in swift

ahmedkaludi#2785 Drop down icon appearing twice problem is fixed in swift

* ahmedkaludi#1400 Added in Master

* ahmedkaludi#1400 Remove previous styling

* ahmedkaludi#2529 back to top functionality improved added in master

* ahmedkaludi#2601 GDPR notification issue fixed which was coming from sticky header and added in master

* ahmedkaludi#1400 Escaping added

* ahmedkaludi#1400 prefix added

* ahmedkaludi#1400 Priority

* change log updated

change log updated

* updated curl call with multi-threading

* Fasterimage code updated

* ahmedkaludi#2787 Default color added

* ahmedkaludi#2702 Added in master

* Changelog updated

Changelog updated

* ahmedkaludi#2804 AMP Footer sidebar is not working in master added in master

* ahmedkaludi#2800 Proper escaping for Title

* version number udated and change log added

version number udated and change log added

* ahmedkaludi#2617 Added in master

* ahmedkaludi#2716 Added in master

* ahmedkaludi#2715 Added in Master

* ahmedkaludi#2738 Added in master

* ahmedkaludi#2733 Added in Master

* ahmedkaludi#2743 Added in master

* ahmedkaludi#2743 Added in master

* ahmedkaludi#2732 Added in master

* ahmedkaludi#2808 No need for this as we have already escaped it in the class

* ahmedkaludi#2797 Added in master

* ahmedkaludi#2795 Added in master

* ahmedkaludi#2714 Added in master

* ahmedkaludi#2809 Added in master

ahmedkaludi#2809 Added in master

* ahmedkaludi#2779 Added in master

* ahmedkaludi#2798 Added in master

* change log updated

change log updated

* ahmedkaludi#2742 Added in master

* ahmedkaludi#2742 No AMP for external links

* ahmedkaludi#2807 backtotop and text repeating mulitple times

ahmedkaludi#2807 backtotop and text repeating mulitple times

* Proper escaping

* Change log updated-2

Change log updated-2

* ahmedkaludi#2822 added in master

* ahmedkaludi#2821 added in master

* version number & log added

* change log updated

* ahmedkaludi#2838 SD Feature Image Guidlines.

ahmedkaludi#2838 SD Feature Image Guidlines.

* ahmedkaludi#2835 Added in master

* ahmedkaludi#2832 just added the filter in master for using it in our extensions

* version number & log added

* log updated

* ahmedkaludi#2754 Added in master

* ahmedkaludi#2737 Translate added in view non amp text and added in master

* ahmedkaludi#2758 proper condition added for ads css and added in master

* ahmedkaludi#2731 Added in master

* ahmedkaludi#2812 Added in master

* ahmedkaludi#2765 Added im ,aster

* ahmedkaludi#2842 Added in master

* version number & log added

* ahmedkaludi#2816 Added in master

* ahmedkaludi#2653 Converted the static values into array in analytics and added in master

* ahmedkaludi#2816 Remove unwanted code from master

* Revert "ahmedkaludi#2765 Added im ,aster"

This reverts commit bb9483d.

* ahmedkaludi#2765 Added in master

* ahmedkaludi#2816 Improved

* ahmedkaludi#2858 Code improvement to avoid validation issues.

* ahmedkaludi#2859 unexpected '[' fixed and added in master

* ahmedkaludi#2858 Priority matters

* ahmedkaludi#2819  added in master

* ahmedkaludi#2760 Added in master

* Version number & log added

* ahmedkaludi#2864 archive title issue fixed and added in master

* Change log and version number updated

Change log and version number updated

* ahmedkaludi#2863 extra double quotes removed and added in master

* ahmedkaludi#2767 Added in master

* ahmedkaludi#2755 Added in master

* ahmedkaludi#2707 ahmedkaludi#2745 Added in master

* ahmedkaludi#2820 Added in master

* ahmedkaludi#2391 added in master

* ahmedkaludi#2730 Added in master

* ahmedkaludi#2730 Remove extra code

* ahmedkaludi#2853 Added in Master

* ahmedkaludi#2855  added in master

* ahmedkaludi#2837 Added in Master

* ahmedkaludi#2711 Added in master

* ahmedkaludi#2576 Added in master

* Revert "ahmedkaludi#2711 Added in master"

This reverts commit b4bbb3f.

* Version number & log added

* ahmedkaludi#2820 Sanitization added in master

* ahmedkaludi#2870 Category Module for PB resolved

ahmedkaludi#2870 Category Module for PB resolved, this issue is occuring in the master only

* ahmedkaludi#2739 Added in Master

* ahmedkaludi#2721 Added in Master

* ahmedkaludi#2827 Added in master

* ahmedkaludi#2701 Integration with Rank math SEO added in master

* ahmedkaludi#2871 Yoast SEO Title compatibility added in master

* ahmedkaludi#2865 Added in master

* Version number & log added

Version number & log added

* ahmedkaludi#2827 Code improvement added in Master

* ahmedkaludi#2751 Added in Master and also updated the sanitize color function

* ahmedkaludi#2880 Added in master

* ahmedkaludi#2757 Added in master

* ahmedkaludi#2751 Added in Master

* ahmedkaludi#2880 To avoid errors with FrontPage and Blog

* ahmedkaludi#2880 No need for this

* ahmedkaludi#2854 Added in master

* ahmedkaludi#2711 Added in master

* ahmedkaludi#1947 Added in master

* Link to Non-AMP for related posts in swift theme

Proper link to Non-AMP for related posts in swift theme added ( issue occured when mobile redirection is enabled )

* ahmedkaludi#2387 Added in master

* ahmedkaludi#2537 Added in master

* Add missed prefix in the function

* ahmedkaludi#2757 condition for Homepage CSS added

* ahmedkaludi#2757 condition improved

* ahmedkaludi#2839 Added in master

* ahmedkaludi#2873 added in master

* ahmedkaludi#2873 Resolve image issue in Master

* Version number & log added

* Revert "Version number & log added"

This reverts commit 5057ee6.

* Version number & log added

* ahmedkaludi#2865 minor issue resolved

* ahmedkaludi#2894 Backward Compatibility for Yoast and All in One SEO options

* ahmedkaludi#2894 Update the options on update

* version number & log added

* Update thirdparty-compatibility.php

* Revert "Update thirdparty-compatibility.php"

This reverts commit cf2660c.

* ahmedkaludi#2718 added options and condition in master

* ahmedkaludi#2778 Added in master

* ahmedkaludi#2665 Added in Master

* ahmedkaludi#2793 Added in master

* version number & log added

* ahmedkaludi#2718 levelup styling merged into master

ahmedkaludi#2718 levelup styling merged into master

* ahmedkaludi#2718 added closing condition

ahmedkaludi#2718 added closing condition

* ahmedkaludi#2718 removed the double instance of the styling

ahmedkaludi#2718 removed the double instance of the styling

* ahmedkaludi#2887 Added in Master

* ahmedkaludi#2887 debug warning removed due null value passed

ahmedkaludi#2887 debug warning removed due null value passed

* Offer icon removed and download added

* change log updated

change log updated

* ahmedkaludi#2784 removed the control for now

ahmedkaludi#2784 removed the control for now

* ahmedkaludi#2756 Added in master

* ahmedkaludi#2363 Added in master

* ahmedkaludi#2753 Added in master

* Credits added for Tablet and Mobile deduction library

Credits added for Tablet and Mobile deduction library

* ahmedkaludi#2593 Added in master

* ahmedkaludi#2544 Added in master

* ahmedkaludi#2435 Added in master

* ahmedkaludi#2823 Added in master

* ahmedkaludi#2436 Added in mater mobile redirection

* ahmedkaludi#2895 Added to master Changes to integer for wp_trim_words

* Version number & log added

* ahmedkaludi#2592 added in master For social links

* ahmedkaludi#2895 removed php warning undefined index

* ahmedkaludi#2897 added post type support on menu link, And improce ampforwp_get_all_post_types function

* ahmedkaludi#2866 Added message if amp content editor is empty and checked

* Revert "ahmedkaludi#2866 Added message if amp content editor is empty and checked"

This reverts commit c0cfb70.

* Revert "ahmedkaludi#2897 added post type support on menu link, And improce ampforwp_get_all_post_types function"

This reverts commit 7001bbd.

* Added browserstack logo in the readme file

* ahmedkaludi#2899 Debug errors fixed in master

* Use 0.1 instead of latest.

with 'latest' its trying to take the latest scripts not stable

* ahmedkaludi#2898 Code improvement

* Use 0.1 only for amp-carousel

* ahmedkaludi#2876 Added in Master

* ahmedkaludi#2003 Added in master the oembed check

ahmedkaludi#2003 Added in master the oembed check

* ahmedkaludi#2884 Added in Master

* ahmedkaludi#2893 Added in master

*  ahmedkaludi#2614 + ahmedkaludi#2900  added to master For static page template issue resolve

* ahmedkaludi#2879 Adding to master Added fix for Warnings codes

* ahmedkaludi#2910 added to master Fix added

* Revert "ahmedkaludi#2876 Added in Master"

This reverts commit 9210d25.

* ahmedkaludi#2910 adding to master by mistak removed

* Version number & log added

* Version number & log added-part (2)

* ahmedkaludi#2913 Added in Master

* ahmedkaludi#2817 Added in master

* ahmedkaludi#2746 Added in master

* ahmedkaludi#2624 Added in master

* ahmedkaludi#2712 Added in master

* ahmedkaludi#2624 Added in master

* ahmedkaludi#2681 Added in master

* version number & log added

* ahmedkaludi#2515 Added in master

* ahmedkaludi#2589 Added in master

* ahmedkaludi#2552 Added in master

* ahmedkaludi#2447 Added in master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pegazee pegazee

Labels
bug
Projects
None yet
Milestone
Wave
Development

No branches or pull requests
4 participants
@ahmedkaludi @ajeetku @pegazee @HANEEFRIYAZ