Skip to content

Conversation

@ahochsteger
Copy link
Owner

Description

This PR introduces a new expression language that is more consistent and provides better extensibility for future enhancements.

Since this PR is a major change here are some more details of the many changes that are contained:

  • add new expression language {{...}} with more flexibility
  • provide backward-compatibility with old expression syntax ${...}
  • add functions parseDate, formatDate, offsetDate, join
  • add date expression examples
  • add legacy expression examples
  • handle non-published branches in clasp.sh
  • add update-parser.sh to generate antlr4-based parser
  • improve testing of log actions
  • add expectations to e2e tests
  • refactor log message cutoff
  • improve action execution results
  • add log redaction mode
  • add MockFactory.newMockFromExample()
  • add more babel plugins for GAS compatibility

Fixes #345

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Other type of change: Major refactorings included

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12502932002

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2274 of 2678 (84.91%) changed or added relevant lines in 20 files are covered.
  • 37 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-2.3%) to 89.61%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/utils/UtilityTypes.ts 0 1 0.0%
src/lib/expr/ExprFilter.ts 329 333 98.8%
src/lib/processors/MessageProcessor.ts 0 4 0.0%
src/lib/expr/generated/ExprLexer.ts 302 318 94.97%
src/lib/e2e/E2E.ts 9 28 32.14%
src/lib/expr/ExprEvaluator.ts 274 296 92.57%
src/lib/expr/generated/ExprParser.ts 1051 1389 75.67%
Files with Coverage Reduction New Missed Lines %
src/lib/e2e/E2E.ts 1 78.87%
src/lib/utils/Timer.ts 8 67.35%
src/lib/processors/MessageProcessor.ts 28 85.34%
Totals Coverage Status
Change from base Build 12289022038: -2.3%
Covered Lines: 8590
Relevant Lines: 9446

💛 - Coveralls

* add new expression language `{{...}}` with more flexibility
* provide backward-compatibility with old expression syntax `${...}`
* add functions parseDate, formatDate, offsetDate, join
* add date expression examples
* add legacy expression examples
* handle non-published branches in clasp.sh
* add update-parser.sh to generate antlr4-based parser
* improve testing of log actions
* add expectations to e2e tests
* refactor log message cutoff
* improve action execution results
* add log redaction mode
* add MockFactory.newMockFromExample()
* add more babel plugins for GAS compatibility
@sonarqubecloud
Copy link

@ahochsteger ahochsteger merged commit 4ae39f5 into main Dec 26, 2024
6 checks passed
@ahochsteger ahochsteger deleted the feat-add-date-parsing branch December 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use custom date format for parsing date values

3 participants