fix: Count unselected section candidates as completed in SimpleProgressDisplay

[ahogappa]

Summary

• Fix task count mismatch in SimpleProgressDisplay when using sections
• Track section candidates and mark unselected ones as completed when a section implementation is selected
• Ensures total count remains constant throughout execution and matches completed count at the end

Problem

Previously, unselected section implementation candidates caused a mismatch between completed tasks and total tasks in the final display (e.g., "3/5" instead of "5/5").

Solution

• Added @section_candidates to track section class → candidate classes mapping
• Added collect_section_candidates method to build the mapping from the tree structure
• Modified on_section_impl_registered to mark unselected candidates as completed (skipped)

Test plan

• All existing tests pass
• Code style check passes

🤖 Generated with Claude Code

Summary by CodeRabbit

• Improvements
  • Enhanced progress tracking for section implementations with improved candidate management, ensuring unselected candidates are properly accounted for in progress reporting and display.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Changes to SimpleProgressDisplay introduce state tracking for section implementation candidates. The class now collects candidate implementations during tree construction, marks unselected candidates as completed after registration, and exposes candidates through a new instance variable for external access.

Changes

Cohort / File(s)	Summary
Section Candidate Tracking lib/taski/execution/simple_progress_display.rb	Initialize @section_candidates instance variable to store section class → candidate implementation mappings. Introduce collect_section_candidates(node) helper method to recursively traverse and populate candidates from tree nodes. After tree building, invoke candidate collection to establish the complete mapping.
Candidate Completion Logic lib/taski/execution/simple_progress_display.rb	Modify on_section_impl_registered method signature (remove underscore prefix from section_class parameter). After implementation registration, mark all unselected candidates for the section by updating their TaskProgress run_state to :completed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor: extract BaseProgressDisplay class from progress displays #117: Directly modifies SimpleProgressDisplay class with changes to on_section_impl_registered signature and @section_candidates tracking logic in the same file.
• feat: add simple one-line progress display mode #112: Related modifications to Taski::Execution::SimpleProgressDisplay including method signature updates and candidate collection behavior in the same class.

Poem

🐰 A rabbit hops through task trees tall,
Collecting candidates, marking all,
Unselected ones get completed with grace,
Section tracking finds its rightful place! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: marking unselected section candidates as completed in SimpleProgressDisplay to fix task count mismatch.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}