Skip to content

ci: check ocaml 5#24

Merged
Khady merged 3 commits intomasterfrom
louis/ocaml5
Apr 8, 2024
Merged

ci: check ocaml 5#24
Khady merged 3 commits intomasterfrom
louis/ocaml5

Conversation

@Khady
Copy link
Copy Markdown
Contributor

@Khady Khady commented Apr 8, 2024

Make sure that devkit compiles on ocaml 5.

For now it depends on a unreleased version of libevent.

There is also a warning that would be nice to fix, but it's not blocking:

File "httpev.ml", line 146, characters 33-46:
146 |     match Unix.getsockopt_int fd Unix.SO_ERROR with
                                       ^^^^^^^^^^^^^
Alert deprecated: SO_ERROR
Use Unix.getsockopt_error instead.

File "httpev.ml", line 819, characters 57-70:
819 | let check_req req = match Unix.getsockopt_int req.socket Unix.SO_ERROR with 0 -> `Ok | n -> `Error n
                                                               ^^^^^^^^^^^^^
Alert deprecated: SO_ERROR
Use Unix.getsockopt_error instead.

Khady added 3 commits April 8, 2024 02:44
Needed to support ocaml 5 until a new version of libevent is released
@Khady Khady merged commit b2944d9 into master Apr 8, 2024
@Khady Khady deleted the louis/ocaml5 branch April 8, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant