[Storage.save_as] do not clobber non-regular files#28
Merged
arvidj merged 1 commit intoahrefs:masterfrom Apr 27, 2026
Merged
Conversation
arvidj
force-pushed
the
aj/inf-320-no-clobber-null
branch
2 times, most recently
from
ba88948 to
d7e8001
Compare
arvidj
force-pushed
the
aj/inf-320-no-clobber-null
branch
from
d7e8001 to
32f693f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storage.save_aschecks whether the target file is regular before attempting the "write to temp, rename temp to file" procedure. If regular, just write directly to the file.