Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 14, 2025

@ddelange
Copy link
Contributor

what's the use-case here, since this package does nothing free-threading related?

@cclauss
Copy link
Contributor Author

cclauss commented Oct 14, 2025

https://github.com/search?q=repo%3Aahupp%2Fpython-magic%20threading is light use of the threading, but that might change over time, and it is better to have guardrails 🚧 in place than drive off the mountain ⛰️ .

If you want, we can close.

@ddelange
Copy link
Contributor

no all good! just curious 👍

@ddelange
Copy link
Contributor

see commit description: 8a35137

might make sense to add a small test in this PR?

@ddelange
Copy link
Contributor

ddelange commented Oct 14, 2025

could argue there should be a global variable LOCK = threading.Lock(), which is used as lock keyword argument default value in the global scope from_buffer, from_file, from_descriptor functions, because those are the functions that are not thread-safe to begin with

@cclauss
Copy link
Contributor Author

cclauss commented Oct 14, 2025

Cool! Let's do this. I will close this PR with unmerged commits. Please recreate it and add the tests that you envision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants