Add free-threaded python to CI including multithreading test #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelange
commented
Oct 14, 2025
magic/__init__.py
Outdated
Comment on lines
316
to
317
| # libmagic is not thread-safe: guard for concurrent calls on a global scope | ||
| LOCK = threading.Lock() |
There was a problem hiding this comment.
@cclauss I realized there is no reason to allow passing a custom lock
ddelange
force-pushed
the
free-threading
branch
from
17b54b0 to
fe2cb91
Compare
ddelange
changed the title
ddelange
force-pushed
the
free-threading
branch
2 times, most recently
from
74dfc08 to
79b6d26
Compare
cclauss
reviewed
Oct 14, 2025
ddelange
force-pushed
the
free-threading
branch
from
79b6d26 to
5b1d27c
Compare
cclauss
reviewed
Oct 14, 2025
ddelange
commented
Oct 14, 2025
cclauss
approved these changes
Oct 14, 2025
This reverts commit f2ac98d.
ddelange
changed the title
|
simplified the diff here because the global libmagic functions are in fact thread-safe as long as you call them with a different cookie. so having the lock inside the Magic class is in fact correct. |
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #357, follow-up on 8a35137