refactor(components): improve select-based model picker flows#18
Merged
Conversation
It uses `@inkjs/ui`’s `Option`/`SelectProps` types, accepts `children` for the content above the select, and owns the shared `Esc` handling for select-backed prompts. Used in: - ModelPicker - PlanApproval - ToolApproval
With `@inkjs/ui` `Select`, when `defaultValue` is already selected, pressing `Enter` on that same option does not give you a new `onChange` event, because the value did not change. So if you want to “confirm the current model and close the picker”, `onChange` alone is not enough. That is why `ModelPicker` has two cancel paths: 1. `Esc` dismisses the picker via `SelectPrompt` 2. `Enter` confirms the current model when the select is already on `defaultValue` in `ModelPicker
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Refine the select-based model picker flow and reduce duplication around prompt-style selects in the TUI.
What is the current behavior?
The model picker and approval flows each render their own select shell,
ModelPickeruses a lessprecise callback name for closing, and the current model is not promoted to the top of the fetched model
list.
What is the new behavior?
A shared
SelectPromptcomponent now wraps select-based prompt UIs,ModelPickerusesonClosetobetter reflect both dismiss and confirm-close behavior, and the current model is shown first in the
model list when it is available. Model picker coverage was also expanded around ordering and close
behavior.
Checklist: