fix(vite): bundle cli for npx runtime#4
Merged
Merged
Conversation
Changed the build to target Node SSR instead of Vite’s default client/lib pipeline, and stopped externalizing the TUI stack. The relevant change is in `vite.config.mts:6: build.ssr = 'src/cli.ts'`, a fixed `cli.js` entry name, and removal of `react`/`ink`/`@inkjs/ui` from external. That removes the emitted Rolldown fallback that was throwing `Calling require for "react"` when the binary was launched via `npx`. The new build no longer contains that runtime stub, and `node dist/cli.js --help` now runs successfully.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
This fixes a packaging/runtime bug where the published CLI could fail when invoked via
npxbecause the Vite/Rolldown output left the TUI stack externalized in a way that triggered a runtimerequire("react")error. It also adds a CI smoke test to catch the same packaged CLI regression in the future.What is the current behavior?
The built CLI could throw
Error: Callingrequirefor "react" in an environment that doesn't expose therequirefunctionwhen run from annpx-style environment. The existing GitHub Actions workflow built and installed the package globally, but it did not explicitly exercise the packed tarball throughnpm execfrom an isolated temp directory.What is the new behavior?
The CLI is now built as a Node SSR bundle so the TUI stack is bundled correctly for packaged execution, and the test workflow now verifies the packed CLI via
npm execto cover thenpxpath.Checklist: