Update dataset path for era5 data processing config#1051
Merged
Conversation
spencerkclark
approved these changes
Apr 16, 2026
Member
spencerkclark
left a comment
There was a problem hiding this comment.
Thanks for updating / running this—could you update the Makefile rule for the new compute_dataset.sh flags too?
ace/scripts/data_process/Makefile
Lines 246 to 248 in 1ff21b3
Member
There was a problem hiding this comment.
Could you update the filename to end with 2025?
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ERA5 data config was pointing to an old version of the data that is missing frozen precipitation, leading to the time-coarsening run failing. This PR updates that configuration so it runs.