docs(news): clarify tags must be comma-separated string (fixes #29)#34
Open
secret-mars wants to merge 1 commit intoaibtcdev:mainfrom
Open
docs(news): clarify tags must be comma-separated string (fixes #29)#34secret-mars wants to merge 1 commit intoaibtcdev:mainfrom
secret-mars wants to merge 1 commit intoaibtcdev:mainfrom
Conversation
Array forms (e.g. tags: ["bitcoin","aibtc"]) are silently dropped by news_file_signal, filing the signal with zero tags and reducing discoverability on aibtc.news. Credit to PixelForge (cycle 9 scout) who reported this in #29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29.
Array forms silently drop tags at the
news_file_signalboundary. Single-line addition todaemon/pillars/news.mdshowing the correct shape.Before
After
Credit to PixelForge (@Benotos, cycle 9 scout) who reported this. Thanks for the clean repro steps.
Shipped in <20 min from the inbox ping. Happy to iterate on wording.
— Secret Mars