chore(validate): fix frontmatter on 3 pre-existing skills

[whoabuddy]

What broke and why

Three skills were admin-merged on 2026-04-08 with the CI job Typecheck, validate, and manifest freshness in FAILURE state. The Zod-tier frontmatter validation rules were tightened in PR #135 (merged 2026-03-13), three weeks before these PRs landed. Branch protection on main is not currently requiring the CI job to pass, which allowed them through.

Running bun run scripts/validate-frontmatter.ts --skip-spec on clean main before this fix produced:

Results: 149 passed, 3 failed, 152 total

Failures were:

Skill	Failure	Introduced by
hermetica-yield-rotator/SKILL.md	user-invocable: "true" — rule requires "false"	#273
jingswap-cycle-agent/SKILL.md	tags outside controlled vocab; requires is an MCP tool name, not a skill dir	#294
sbtc-auto-funnel/SKILL.md	tags outside controlled vocab	#278

Full investigation context: .planning/2026-04-15-bff-comp-review-4/FINDINGS.md

Changes (frontmatter only — no code changes)

hermetica-yield-rotator/SKILL.md (PR #273)

• user-invocable: "true" → "false" (skills are invoked by Claude Code, not end users)
• tags: trimmed to controlled vocab → "defi, write, mainnet-only, l2"

jingswap-cycle-agent/SKILL.md (PR #294)

• requires: "jingswap_deposit_stx (aibtc MCP) for live execution" → "wallet, jingswap" (valid skill directory names)
• tags: trimmed to controlled vocab → "defi, write, mainnet-only, l2"

sbtc-auto-funnel/SKILL.md (PR #278)

• tags: trimmed to controlled vocab → "defi, write, mainnet-only, requires-funds, l2"

skills.json

Regenerated via bun run manifest to reflect the three frontmatter fixes.

Verification

After this change:

bun run scripts/validate-frontmatter.ts --skip-spec
Results: 152 passed, 0 failed, 152 total

bun run typecheck
(no output — clean)

Flag for repo owner

Branch protection on main should require the Typecheck, validate, and manifest freshness CI job to pass before merging. Without that requirement, future comp batches can admin-merge past red CI and introduce the same category of failures. This is a GitHub repository settings change and is not part of this PR — flagging here for awareness.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes repository frontmatter validation failures introduced by three previously merged skills by aligning their SKILL.md metadata with the repo’s stricter Zod-tier rules (controlled tag vocabulary, user-invocable: "false", and requires referencing real skill dirs). Regenerates skills.json to reflect the corrected frontmatter.

Changes:

• Normalize metadata.user-invocable to "false" and trim metadata.tags to the controlled vocabulary for affected skills.
• Replace invalid free-form metadata.requires text with valid skill directory references.
• Regenerate skills.json manifest after frontmatter fixes.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
skills.json	Updates generated timestamp and reflects corrected requires/tags/userInvocable derived from SKILL.md frontmatter.
sbtc-auto-funnel/SKILL.md	Replaces invalid tags with controlled-vocab tags.
jingswap-cycle-agent/SKILL.md	Fixes requires to valid skill dirs and trims tags to controlled vocab.
hermetica-yield-rotator/SKILL.md	Sets user-invocable to "false" and trims tags to controlled vocab.
.gitignore	Ignores .quests/ directory (local-only).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.