fix: patch xml2js CVE + route OpenCode review through hush gateway#32
Closed
byapparov wants to merge 6 commits into
Closed
fix: patch xml2js CVE + route OpenCode review through hush gateway#32byapparov wants to merge 6 commits into
byapparov wants to merge 6 commits into
Conversation
…hush - Add npm override for xml2js ^0.6.2 (fixes Dependabot alert #1, prototype pollution in transitive dep blessed-contrib → map-canvas → xml2js) - Integrate hush@0.1.7 into the OpenCode AI review workflow: install and start the hush gateway on :4000, copy the hush plugin, configure opencode.json to route API calls through the proxy. Defense-in-depth: plugin blocks sensitive file reads, proxy redacts PII from normal file content before it reaches the model. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report
File CoverageNo changed files found. |
Running bare `hush` in the repo checkout resolves to the local package.json bin entry (dist/cli.js) which doesn't exist in CI since this workflow doesn't build. Use $(npm prefix -g)/bin/hush to reliably invoke the globally-installed binary. Also adds a health-check with ::error:: annotation so the job fails fast with a clear message if the gateway doesn't start. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Review: Hush Semantic Gateway PR #32Reviewed SHA: b50a99e SummaryThis PR addresses xml2js CVE-2025-XXXX via npm overrides and integrates Hush gateway into the CI review workflow for The core redaction/proxy logic appears unchanged and well-tested (108 tests passing, 82.2% coverage). 1. Redaction LogicStrengths:
Minor concerns:
2. Streaming IntegrityStrengths:
Minor issues:
3. SecurityStrengths:
No issues found:
4. ReliabilityStrengths:
No issues found. PR Changes (xml2js + CI workflow)Approved:
Reviewed SHA: b50a99e |
…ns them Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm overridesentry forxml2js ^0.6.2to fix the prototype pollution vulnerability in the transitive dependency chainblessed-contrib → map-canvas → xml2js..github/workflows/opencode-review.ymlto install and start the hush gateway (hush@0.1.7) on:4000, copy the hush plugin, and configureopencode.jsonto route API calls through the proxy. This provides defense-in-depth: the plugin blocks sensitive file reads, and the proxy redacts PII from normal file content before it reaches the model.Test plan
npm installresolvesxml2jsto>=0.6.2(no more Dependabot alert)🤖 Generated with Claude Code