More fixes for Windows #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @cwenger! Could you actually implement the shorts/ints/longs with stdint.h as in @nchernia's suggestion? #69 (review) |
Collaborator
Author
|
@sa501428 Sure I'll give it a try! |
Collaborator
Author
|
Ok @sa501428 see what you think. I wasn't sure if I should use the fixed size integers everywhere or only for data read from .hic files and I ended up somewhere in between. |
Collaborator
Author
|
@sa501428 Just seeing if you've had an opportunity to take a look at these changes yet. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.