Skip to content

Failed to accept optimize React.memo()  #1148

@mr-rime

Description

@mr-rime

What version of million are you using?

latest version of Million.js

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Windows

What browser are you using?

Chrome - Edge

Describe the Bug

when i try to accept any optimization with React.memo it throws this error

Failed to accept Optimize 2 re-renders: React.memo SearchableSelect
not only in this component , it throws with any component needs optimization using React.memo()
it shows me the changes but it doesn't apply them

here is some images:

  • old component

image

  • new changes

image

  • the error

image

What's the expected result?

it should accept the changes and apply them on the component

Link to Minimal Reproducible Example

.

Participation

  • I am willing to submit a pull request for this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions