Skip to content

Move daily notes to top of markdown output, right after the date header #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidmax merged 2 commits into from
May 6, 2026
Merged

Move daily notes to top of markdown output, right after the date header #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71c7b68
Move daily notes to top of markdown output, right after the date header
claude May 6, 2026
c0b50b3
Fix stale local markdown helper copies in utils.test.ts
claude May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions client/src/pages/home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ function generateCyclingMarkdown(data: InsertWorkout): string {
markdown += data.description + '\n';
}

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

Expand All @@ -247,10 +243,6 @@ function generateRestMarkdown(data: InsertWorkout): string {
}
if (data.weight) markdown += `Weight: ${data.weight}\n`;

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

Expand All @@ -263,16 +255,16 @@ function generateOtherMarkdown(data: InsertWorkout): string {
markdown += '\n' + formatBulletPoints(data.activityNotes) + '\n';
}

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

function generateMarkdown(data: InsertWorkout): string {
let markdown = `---\n## ${formatWorkoutDate(data.workoutDate)}\n\n`;

if (data.dailyNotes) {
markdown += formatBulletPoints(data.dailyNotes) + '\n\n';
}

switch (data.entryType) {
case "rest":
markdown += generateRestMarkdown(data);
Expand Down
36 changes: 19 additions & 17 deletions client/src/test/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ function generateCyclingMarkdown(data: InsertWorkout): string {
markdown += data.description + '\n';
}

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

Expand All @@ -137,10 +133,6 @@ function generateRestMarkdown(data: InsertWorkout): string {
}
if (data.weight) markdown += `Weight: ${data.weight}\n`;

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

Expand All @@ -153,16 +145,16 @@ function generateOtherMarkdown(data: InsertWorkout): string {
markdown += '\n' + formatBulletPoints(data.activityNotes) + '\n';
}

if (data.dailyNotes) {
markdown += '\n' + formatBulletPoints(data.dailyNotes) + '\n';
}

return markdown;
}

function generateMarkdown(data: InsertWorkout): string {
let markdown = `---\n## ${formatWorkoutDate(data.workoutDate)}\n\n`;

if (data.dailyNotes) {
markdown += formatBulletPoints(data.dailyNotes) + '\n\n';
}

switch (data.entryType) {
case "rest":
markdown += generateRestMarkdown(data);
Expand Down Expand Up @@ -252,6 +244,16 @@ describe('generateMarkdown — rest output', () => {
expect(md).toContain('- Decided to skip training');
});

it('daily notes appear before Rest Day marker when both present', () => {
const md = generateMarkdown({
...baseRest,
dailyNotes: 'Feeling off today',
});
const dailyIdx = md.indexOf('- Feeling off today');
const restDayIdx = md.indexOf('Rest Day');
expect(dailyIdx).toBeLessThan(restDayIdx);
});

it('excludes cycling-only fields', () => {
const md = generateMarkdown({
...baseRest,
Expand Down Expand Up @@ -333,7 +335,7 @@ describe('generateMarkdown — other output', () => {
expect(md).not.toContain('TSS:');
});

it('includes daily notes as bullets after activity notes', () => {
it('includes daily notes as bullets before activity notes', () => {
const md = generateMarkdown({
...baseOther,
activityGoal: 'MFR',
Expand All @@ -345,7 +347,7 @@ describe('generateMarkdown — other output', () => {
expect(md).toContain('- Apartment move stress');
const activityIdx = md.indexOf('- Full body protocol v3');
const dailyIdx = md.indexOf('- Long day at work');
expect(activityIdx).toBeLessThan(dailyIdx);
expect(dailyIdx).toBeLessThan(activityIdx);
});

it('includes daily notes when no activity notes', () => {
Expand All @@ -366,7 +368,7 @@ describe('generateMarkdown — cycling daily notes', () => {
feel: 'G',
};

it('includes daily notes at end of cycling output', () => {
it('includes daily notes in cycling output', () => {
const md = generateMarkdown({
...base,
dailyNotes: 'New apartment adaptation\nBarometric pressure dropped',
Expand All @@ -375,15 +377,15 @@ describe('generateMarkdown — cycling daily notes', () => {
expect(md).toContain('- Barometric pressure dropped');
});

it('daily notes appear after Planned when both present', () => {
it('daily notes appear before Planned when both present', () => {
const md = generateMarkdown({
...base,
description: 'Sweet Spot Base II',
dailyNotes: 'Commute stress',
});
const plannedIdx = md.indexOf('Planned');
const dailyIdx = md.indexOf('- Commute stress');
expect(plannedIdx).toBeLessThan(dailyIdx);
expect(dailyIdx).toBeLessThan(plannedIdx);
});

it('omits daily notes section when empty', () => {
Expand Down
Loading