no RTTI & fix compile err when !USE_PLACES_FEATURE#166
Merged
aiekick merged 1 commit intoaiekick:masterfrom Feb 21, 2024
mataron:master
Merged
no RTTI & fix compile err when !USE_PLACES_FEATURE#166aiekick merged 1 commit intoaiekick:masterfrom mataron:master
aiekick merged 1 commit intoaiekick:masterfrom
mataron:master
Conversation
Owner
|
Hello, arf sorry, im working on this feature so maybe not stable in all cases, even compilation. not sure what understand by : "On the other hand, the no RTTI change is a matter of preference :)" |
Contributor
Author
|
typeid() is perfectly safe, AFAIK. Cheers! |
Owner
|
ok thanks. will keep that in mind :) thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The USE_PLACES_FEATURE related change fixes a compilation error.
On the other hand, the no RTTI change is a matter of preference :)
Nice lib!
BR