Skip to content

no RTTI & fix compile err when !USE_PLACES_FEATURE#166

Merged
aiekick merged 1 commit intoaiekick:masterfrom
mataron:master
Feb 21, 2024
Merged

no RTTI & fix compile err when !USE_PLACES_FEATURE#166
aiekick merged 1 commit intoaiekick:masterfrom
mataron:master

Conversation

@mataron
Copy link
Copy Markdown
Contributor

@mataron mataron commented Feb 21, 2024

Hi,

The USE_PLACES_FEATURE related change fixes a compilation error.

On the other hand, the no RTTI change is a matter of preference :)

Nice lib!

BR

@aiekick
Copy link
Copy Markdown
Owner

aiekick commented Feb 21, 2024

Hello,

arf sorry, im working on this feature so maybe not stable in all cases, even compilation.

not sure what understand by : "On the other hand, the no RTTI change is a matter of preference :)"
typeid is not safe ? (btw thanks i prefer your way :))

@aiekick aiekick merged commit 34bd2cd into aiekick:master Feb 21, 2024
@mataron
Copy link
Copy Markdown
Contributor Author

mataron commented Feb 21, 2024

typeid() is perfectly safe, AFAIK.
It's just that there are cases when it's not available (due to custom RTTI implementations). In my case I compile the project with -fno-rtti (clang/gcc), so it's just not there.

Cheers!

@aiekick
Copy link
Copy Markdown
Owner

aiekick commented Feb 21, 2024

ok thanks.

will keep that in mind :)

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants