Skip to content

test: update bucket used for E2E tests#454

Merged
olivermeyer merged 4 commits intomainfrom
test/new-slide-urls
Mar 2, 2026
Merged

test: update bucket used for E2E tests#454
olivermeyer merged 4 commits intomainfrom
test/new-slide-urls

Conversation

@ari-nz
Copy link
Collaborator

@ari-nz ari-nz commented Feb 27, 2026

Copilot AI review requested due to automatic review settings February 27, 2026 17:25
str,
typer.Argument(
help="URL to download."
" Example: gs://aignx-storage-service-dev/sample_data_formatted/9375e3ed-28d2-4cf3-9fb9-8df9d11a6627.tiff"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure this will still work for a non aignx user

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates test slide GCS URLs to point to a non-deprecated bucket, and aligns related user-facing examples/documentation strings in the dataset download CLI/service.

Changes:

  • Update SPOT_*_GS_URL constants in tests to use the new gs://aignostics-platform-ext-a4f7e9/python-sdk-tests/he-tme/slides/... bucket path.
  • Refresh example URLs in dataset service docstring and CLI help text.
  • Adjust examples/script.py to reuse slide constants (currently via tests.constants_test), and extend .gitignore for local editor/config files.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/constants_test.py Switches slide GCS URLs to the new non-deprecated bucket.
src/aignostics/dataset/_service.py Updates docstring example to reflect the new bucket URL format.
src/aignostics/dataset/_cli.py Updates CLI help example URL to the new bucket path.
examples/script.py Replaces hardcoded slide metadata/URL with imported constants (currently from tests).
.gitignore Ignores .vscode/* and **/settings.local.json local configuration files.

Comment on lines 6 to 13
from tests.constants_test import (
SPOT_1_CRC32C,
SPOT_1_GS_URL,
SPOT_1_HEIGHT,
SPOT_1_RESOLUTION_MPP,
SPOT_1_WIDTH,
)

Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples is packaged into the wheel (see pyproject.toml), but tests is not. Importing tests.constants_test will therefore raise ModuleNotFoundError for installed users running this example. Consider moving these shared slide constants into a runtime module (e.g., src/aignostics/...) or duplicating them locally within examples/ so the example is self-contained.

Suggested change
from tests.constants_test import (
SPOT_1_CRC32C,
SPOT_1_GS_URL,
SPOT_1_HEIGHT,
SPOT_1_RESOLUTION_MPP,
SPOT_1_WIDTH,
)
# Constants for the example slide; duplicated here so the example is self-contained
# and does not depend on the uninstalled `tests` package.
SPOT_1_CRC32C = "INSERT_BASE64_CRC32C_CHECKSUM_HERE"
SPOT_1_GS_URL = "gs://INSERT_BUCKET_NAME/INSERT_OBJECT_PATH"
SPOT_1_HEIGHT = 0
SPOT_1_RESOLUTION_MPP = 0.0
SPOT_1_WIDTH = 0

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/aignostics/dataset/_cli.py 92.39% <ø> (ø)
src/aignostics/dataset/_service.py 76.71% <ø> (ø)

... and 11 files with indirect coverage changes

@olivermeyer olivermeyer force-pushed the test/new-slide-urls branch from d965753 to a1cd355 Compare March 2, 2026 13:55
Copilot AI review requested due to automatic review settings March 2, 2026 13:55
@olivermeyer olivermeyer force-pushed the test/new-slide-urls branch from 7f4bffe to e97fd43 Compare March 2, 2026 13:58
@olivermeyer olivermeyer changed the title Test - add new slide urls for a non-deprecated bucket tests: update bucket used for E2E tests Mar 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

examples/script.py:12

  • examples is packaged/distributed (see pyproject), but tests is not. Importing these constants from tests.constants_test will make this example fail for end users running it from an installed wheel/sdist. Please move the slide URL/metadata constants into examples (e.g., an examples.constants module) or keep the values local to the script so it has no dependency on the test suite.

# initialize the client
client = platform.Client()
# submit application run
# for details, see the IPython or Marimo notebooks for a detailed explanation of the payload
application_run = client.runs.submit(
    application_id="two-task-dummy",

src/aignostics/dataset/_cli.py:181

  • This CLI help example was updated, but CLI_REFERENCE.md is generated from the Typer app and still contains the old bucket URL example. Please regenerate the CLI reference (via the repo’s docs generation workflow) so the published CLI docs match the updated help text.
        str,
        typer.Argument(
            help="URL to download."
            " Example: gs://aignostics-platform-ext-a4f7e9/python-sdk-tests/he-tme/slides/9375e3ed-28d2-4cf3-9fb9-8df9d11a6627.tiff"
        ),

ari-nz and others added 4 commits March 2, 2026 14:59
…ervice account is able to reach

Tests were failing due to a race condition. The test was expecting a run to be processing, but is was failing early due to a USER_ERROR caused by a signed url being created with the wrong permission set
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2026

@olivermeyer olivermeyer changed the title tests: update bucket used for E2E tests test: update bucket used for E2E tests Mar 2, 2026
@olivermeyer
Copy link
Collaborator

macos-15-intel runner failed at test_cli_run_dump_and_update_custom_metadata with what looks like a transient DNS resolution error:

urllib3.exceptions.NameResolutionError: HTTPSConnection(host='platform-staging.aignostics.com', port=443): Failed to resolve 'platform-staging.aignostics.com' ([Errno 8] nodename nor servname provided, or not known)

Merging since this is unlikely to be caused by this PR.

@olivermeyer olivermeyer merged commit 894ee74 into main Mar 2, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants