test: update bucket used for E2E tests#454
Conversation
| str, | ||
| typer.Argument( | ||
| help="URL to download." | ||
| " Example: gs://aignx-storage-service-dev/sample_data_formatted/9375e3ed-28d2-4cf3-9fb9-8df9d11a6627.tiff" |
There was a problem hiding this comment.
I'm unsure this will still work for a non aignx user
There was a problem hiding this comment.
Pull request overview
Updates test slide GCS URLs to point to a non-deprecated bucket, and aligns related user-facing examples/documentation strings in the dataset download CLI/service.
Changes:
- Update
SPOT_*_GS_URLconstants in tests to use the newgs://aignostics-platform-ext-a4f7e9/python-sdk-tests/he-tme/slides/...bucket path. - Refresh example URLs in dataset service docstring and CLI help text.
- Adjust
examples/script.pyto reuse slide constants (currently viatests.constants_test), and extend.gitignorefor local editor/config files.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/constants_test.py | Switches slide GCS URLs to the new non-deprecated bucket. |
| src/aignostics/dataset/_service.py | Updates docstring example to reflect the new bucket URL format. |
| src/aignostics/dataset/_cli.py | Updates CLI help example URL to the new bucket path. |
| examples/script.py | Replaces hardcoded slide metadata/URL with imported constants (currently from tests). |
| .gitignore | Ignores .vscode/* and **/settings.local.json local configuration files. |
examples/script.py
Outdated
| from tests.constants_test import ( | ||
| SPOT_1_CRC32C, | ||
| SPOT_1_GS_URL, | ||
| SPOT_1_HEIGHT, | ||
| SPOT_1_RESOLUTION_MPP, | ||
| SPOT_1_WIDTH, | ||
| ) | ||
|
|
There was a problem hiding this comment.
examples is packaged into the wheel (see pyproject.toml), but tests is not. Importing tests.constants_test will therefore raise ModuleNotFoundError for installed users running this example. Consider moving these shared slide constants into a runtime module (e.g., src/aignostics/...) or duplicating them locally within examples/ so the example is self-contained.
| from tests.constants_test import ( | |
| SPOT_1_CRC32C, | |
| SPOT_1_GS_URL, | |
| SPOT_1_HEIGHT, | |
| SPOT_1_RESOLUTION_MPP, | |
| SPOT_1_WIDTH, | |
| ) | |
| # Constants for the example slide; duplicated here so the example is self-contained | |
| # and does not depend on the uninstalled `tests` package. | |
| SPOT_1_CRC32C = "INSERT_BASE64_CRC32C_CHECKSUM_HERE" | |
| SPOT_1_GS_URL = "gs://INSERT_BUCKET_NAME/INSERT_OBJECT_PATH" | |
| SPOT_1_HEIGHT = 0 | |
| SPOT_1_RESOLUTION_MPP = 0.0 | |
| SPOT_1_WIDTH = 0 |
Codecov Report✅ All modified and coverable lines are covered by tests.
|
d965753 to
a1cd355
Compare
7f4bffe to
e97fd43
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
examples/script.py:12
examplesis packaged/distributed (see pyproject), buttestsis not. Importing these constants fromtests.constants_testwill make this example fail for end users running it from an installed wheel/sdist. Please move the slide URL/metadata constants intoexamples(e.g., anexamples.constantsmodule) or keep the values local to the script so it has no dependency on the test suite.
# initialize the client
client = platform.Client()
# submit application run
# for details, see the IPython or Marimo notebooks for a detailed explanation of the payload
application_run = client.runs.submit(
application_id="two-task-dummy",
src/aignostics/dataset/_cli.py:181
- This CLI help example was updated, but
CLI_REFERENCE.mdis generated from the Typer app and still contains the old bucket URL example. Please regenerate the CLI reference (via the repo’s docs generation workflow) so the published CLI docs match the updated help text.
str,
typer.Argument(
help="URL to download."
" Example: gs://aignostics-platform-ext-a4f7e9/python-sdk-tests/he-tme/slides/9375e3ed-28d2-4cf3-9fb9-8df9d11a6627.tiff"
),
…ervice account is able to reach Tests were failing due to a race condition. The test was expecting a run to be processing, but is was failing early due to a USER_ERROR caused by a signed url being created with the wrong permission set
e97fd43 to
77b176b
Compare
|
|
Merging since this is unlikely to be caused by this PR. |



Triggering a ci run here: https://github.com/aignostics/python-sdk/actions/runs/22497218409