Skip to content

feat(application): add OTHER as valid tissue value in GUI metadata grid#522

Merged
omid-aignostics merged 1 commit intomainfrom
feat/add-other-tissue-value
Mar 31, 2026
Merged

feat(application): add OTHER as valid tissue value in GUI metadata grid#522
omid-aignostics merged 1 commit intomainfrom
feat/add-other-tissue-value

Conversation

@omid-aignostics
Copy link
Copy Markdown
Collaborator

Summary

  • Adds OTHER as a valid tissue value in the GUI metadata grid
  • Updates the dropdown, validation, and cell highlighting to accept OTHER

Notes

  • No changes needed for the CLI or Python library — they already accept any string for tissue

Test plan

  • Verify OTHER appears in the tissue dropdown in the GUI metadata grid
  • Verify selecting OTHER marks the cell green
  • Verify the "Next" button enables when all rows have valid tissue and disease values including OTHER

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds "OTHER" as an accepted tissue value in the Application “Describe” GUI metadata grid, ensuring users can select it and still pass client-side validation and visual validity highlighting.

Changes:

  • Extend tissue validation to treat "OTHER" as a valid value.
  • Add "OTHER" to the tissue dropdown options in the metadata grid.
  • Update tissue cell highlighting rules so "OTHER" is marked as valid (green) rather than invalid (red).

Comment thread src/aignostics/application/_gui/_page_application_describe.py
Comment thread src/aignostics/application/_gui/_page_application_describe.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
...ics/application/_gui/_page_application_describe.py 72.13% <ø> (ø)

... and 1 file with indirect coverage changes

@omid-aignostics omid-aignostics merged commit 15a6063 into main Mar 31, 2026
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants