fix(docs): correct skip:test:long_running label name in CLAUDE.md [PYSDK-89]#577
Merged
helmut-hoffer-von-ankershoffen merged 1 commit intoApr 24, 2026
Conversation
The label uses colons as separators, not underscores. The wrong name caused the label to not be found when creating PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
helmut-hoffer-von-ankershoffen
added
the
skip:test:long_running
Copilot started reviewing on behalf of
helmut-hoffer-von-ankershoffen
April 24, 2026 18:32
View session
|
There was a problem hiding this comment.
Pull request overview
Updates repository-level contributor guidance to use the correct GitHub PR label name for skipping long-running tests, aligning CLAUDE.md with the established label convention used elsewhere in the repo and preventing gh pr edit --add-label failures.
Changes:
- Replaced
skip:test_long_running(underscores) withskip:test:long_running(colons) inCLAUDE.md. - Updated the example
gh pr edit --add-label ...commands to reference the corrected label.
| @@ -32,7 +32,7 @@ If you write code yourself, it is a strict requirement to validate your work on | |||
|
|
|||
| If you you are creating a pull request yourself: | |||
There was a problem hiding this comment.
Line 33 has a duplicated word: "If you you are creating a pull request yourself" → "If you are creating a pull request yourself".
Suggested change
| If you you are creating a pull request yourself: | |
| If you are creating a pull request yourself: |
| If you you are creating a pull request yourself: | ||
|
|
||
| * Add a label skip:test_long_running, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. | ||
| * Add a label skip:test:long_running, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. |
There was a problem hiding this comment.
The label name on this bullet is plain text with punctuation attached ("skip:test:long_running,") which makes it easy to copy/paste incorrectly and is inconsistent with later usage (e.g., skip:test:long_running). Consider formatting the label as inline code and placing the comma outside the code span.
Suggested change
| * Add a label skip:test:long_running, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. | |
| * Add a label `skip:test:long_running`, to skip running long running tests. This is important because some tests in this repository are marked as long_running and can take a significant amount of time to complete. By adding this label, you help ensure that the CI pipeline runs efficiently and avoids unnecessary delays. |
helmut-hoffer-von-ankershoffen
deleted the
fix/PYSDK-89-claude-md-skip-label-name
branch
helmut-hoffer-von-ankershoffen
added
sop:pr-sop-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Resolves PYSDK-89 following PR-SOP-01 Problem Resolution and Non-Conforming Products, part of our ISO 13485-certified QMS | Ketryx Project
Summary
skip:test_long_running(underscores) →skip:test:long_running(colons) inCLAUDE.mdgh pr edit --add-labelto fail with "label not found" when Claude Code created PRs.github/CLAUDE.mdalready used the correct colon form throughoutRoot cause
Implementation error: the label name in
CLAUDE.mdwas written with underscores when the PR label naming convention was established..github/CLAUDE.mdhad the correct form butCLAUDE.mdwas not kept in sync.Test plan
gh pr edit --add-label "skip:test:long_running"succeeds on a test PRCLAUDE.mdno longer containsskip:test_long_runningSupersedes #564 (closed due to branch rename for Jira Development panel linkage).
🤖 Generated with Claude Code