fix(test): pin application version in E2E test#634
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize the application dump-schemata E2E CLI test by pinning the HETA application version so the test won’t break when new HETA versions are released.
Changes:
- Passes
--application-version HETA_APPLICATION_VERSIONto theapplication dump-schemataCLI invocation intest_cli_application_dump_schemata.
Comments suppressed due to low confidence (1)
tests/aignostics/application/cli_test.py:232
- The test now pins
--application-versiontoHETA_APPLICATION_VERSION, but the zip filename assertion still derivesapplication_versionviaApplicationService().application_version(HETA_APPLICATION_ID)(which resolves to the latest version when no version is provided). This can reintroduce the same flakiness when a new HETA version is released because the created zip uses the pinned version while the assertion uses the latest. Use the pinned version when resolvingapplication_version(or build the expected zip path directly fromHETA_APPLICATION_VERSION).
application_version = ApplicationService().application_version(HETA_APPLICATION_ID)
application_version = ApplicationService().application_version(HETA_APPLICATION_ID)
assert result.exit_code == 0
assert "Zipped 11 files" in normalize_output(result.output)
zip_file = sanitize_path(
Path(tmp_path / f"{HETA_APPLICATION_ID}_{application_version.version_number}_schemata.zip")
)
9d079e5 to
46ceb73
Compare
arne-aignx
approved these changes
May 11, 2026
46ceb73 to
d5681e3
Compare
|
|
|
||
|
|
||
| @pytest.mark.e2e | ||
| # @pytest.mark.e2e |
Comment on lines
+208
to
209
| # @pytest.mark.e2e | ||
| @pytest.mark.timeout(timeout=60) |
Codecov Report✅ All modified and coverable lines are covered by tests. |
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pinning the HETA version in
test_cli_application_dump_schematato avoid test failures when new versions are released (e.g https://github.com/aignostics/python-sdk/actions/runs/25661734408/job/75323877792).