-
Notifications
You must be signed in to change notification settings - Fork 0
setup e2e tests #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup e2e tests #33
Conversation
2c9617b to
b5b12a8
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage ? 95.34%
=======================================
Files ? 9
Lines ? 1096
Branches ? 151
=======================================
Hits ? 1045
Misses ? 51
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
79e8931 to
e82be5c
Compare
00f66e5 to
943a248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end (E2E) testing infrastructure for the CLI package and implements a new refresh token login feature.
Key Changes:
- Refresh token authentication: Adds
loginWithRefreshTokenmethod to AuthService enabling login via refresh token - E2E test infrastructure: Creates new E2E test framework with Vitest configuration, test utilities, and smoke tests
- CI/CD integration: Adds GitHub Actions workflow for automated E2E testing on schedule and PR events
- Dependency updates: Updates
@nx/viteto v21.6.6 and addsexecaandfs-extrapackages
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/src/utils/auth.ts | Adds loginWithRefreshToken method and exports token schemas |
| packages/cli/src/utils/auth.spec.ts | Comprehensive unit tests for refresh token login functionality |
| packages/cli/src/cli.ts | Extends login command to accept optional --refreshToken flag |
| packages/cli/src/cli-functions.ts | Adds handleLoginWithRefreshToken wrapper function |
| packages/cli/src/cli-functions.spec.ts | Unit tests for refresh token login handler |
| packages/cli/src/cli.test.ts | Integration test for refresh token login command |
| packages/cli/e2e/vite.config.e2e.ts | Vitest configuration for E2E tests with extended timeouts |
| packages/cli/e2e/vitest.setup.ts | Setup file that authenticates before E2E tests run |
| packages/cli/e2e/utils/command.ts | Utility for executing CLI commands in E2E tests |
| packages/cli/e2e/specs/base.e2e.test.ts | Basic smoke tests for CLI commands |
| .github/workflows/e2e-cli.yml | GitHub Actions workflow for scheduled and on-demand E2E testing |
| packages/cli/project.json | Adds test:e2e target for Nx |
| packages/cli/package.json | Adds E2E test script |
| package.json | Adds workspace-level E2E test script and new dependencies |
| packages/cli/tsconfig.json | Includes E2E directory in TypeScript compilation |
| packages/cli/tsconfig.app.json | Excludes E2E tests from production build |
| tsconfig.eslint.json | Includes E2E directory for linting |
| packages/cli/src/utils/environment.ts | Updates develop environment endpoint domain |
| .gitignore | Adds test-results directory to ignore list |
943a248 to
2a833f3
Compare
santi698
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Great job Nassim, looks very nice.
Just a few small change requests
| "eslint": "^9.31.0", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-plugin-prettier": "^5.5.3", | ||
| "execa": "^9.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santi698 do we need approvals for new libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not if they don't have any license that requires approval
2a833f3 to
ecf5bf5
Compare
0ba41e7 to
d45b59c
Compare
d45b59c to
792dc0d
Compare
|



No description provided.