Skip to content

Remove pyupgrade and flynt pre-commit hooks#203

Merged
GeigerJ2 merged 2 commits intoaiidateam:mainfrom
danielhollas:remove-flynt-pyupgrade
Dec 17, 2025
Merged

Remove pyupgrade and flynt pre-commit hooks#203
GeigerJ2 merged 2 commits intoaiidateam:mainfrom
danielhollas:remove-flynt-pyupgrade

Conversation

@danielhollas
Copy link
Copy Markdown
Contributor

@danielhollas danielhollas commented Dec 8, 2025

Use the corresponding ruff rules instead.
(see also corresponding PR in aiida-core that removed flynt aiidateam/aiida-core#7022)

All the code changes are autofixes from ruff.

Use the corresponding ruff rules instead
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.63%. Comparing base (7b7b593) to head (0e59358).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files           8        8           
  Lines        1931     1932    +1     
=======================================
+ Hits         1924     1925    +1     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GeigerJ2
GeigerJ2 previously approved these changes Dec 15, 2025
Copy link
Copy Markdown
Contributor

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Was actually just waiting for this PR from you :D there are more ruff rules one could auto-apply here, and in aiida-core, e.g., automatically moving imports into if TYPE_CHECKING: blocks, etc. Crazy how many rules actually are there in ruff :3

@danielhollas
Copy link
Copy Markdown
Contributor Author

Oh, whoops, please don't merge yet, I forgot to activate the flynt rules

@danielhollas
Copy link
Copy Markdown
Contributor Author

Should be good now, sorry about that @GeigerJ2

there are more ruff rules one could auto-apply here, and in aiida-core, e.g., automatically moving imports into if TYPE_CHECKING: blocks, etc. Crazy how many rules actually are there in ruff :3

Haha, indeed, we can do that at some point. I think in AiiDAlab we have a few more, e.g. Bugbear. I was also looking into enabling ASYNC rules in aiida-core.

@danielhollas
Copy link
Copy Markdown
Contributor Author

Thanks for the review and approval @GeigerJ2 🫶 Merge is up to you.

@GeigerJ2 GeigerJ2 merged commit e5cb644 into aiidateam:main Dec 17, 2025
20 checks passed
@GeigerJ2
Copy link
Copy Markdown
Contributor

Thanks for the review and approval @GeigerJ2 🫶 Merge is up to you.

Done, thanks again! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants