Conversation
The `PortNamespace` class supports nested namespace hierarchies by
design. However, the `absorb` method, which allows one to absorb the
ports of one port namespace into another, only allows to absorb the
ports wholesale. There are many use cases where one would want to absorb
the ports, but exclude some nested ports. The `exclude` and `include`
rules did not account for this.
Here we make the `absorb` properly recursive and allow the `exclude` and
`include` rules to also target nested ports. For example if the port `a`
in the namespace `base` needs to be excluded, one can now define
`exclude=('base.a')`.
sphuber
force-pushed
the
fix_115_namespace_exclude_include_rules_absorb
branch
from
8b87010 to
3001594
Compare
giovannipizzi
approved these changes
Jun 17, 2019
unkcpz
pushed a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
aiidateam#116) The `PortNamespace` class supports nested namespace hierarchies by design. However, the `absorb` method, which allows one to absorb the ports of one port namespace into another, only allows to absorb the ports wholesale. There are many use cases where one would want to absorb the ports, but exclude some nested ports. The `exclude` and `include` rules did not account for this. Here we make the `absorb` properly recursive and allow the `exclude` and `include` rules to also target nested ports. For example if the port `a` in the namespace `base` needs to be excluded, one can now define `exclude=('base.a')`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
The
PortNamespaceclass supports nested namespace hierarchies bydesign. However, the
absorbmethod, which allows one to absorb theports of one port namespace into another, only allows to absorb the
ports wholesale. There are many use cases where one would want to absorb
the ports, but exclude some nested ports. The
excludeandincluderules did not account for this.
Here we make the
absorbproperly recursive and allow theexcludeandincluderules to also target nested ports. For example if the portain the namespace
baseneeds to be excluded, one can now defineexclude=('base.a').