Do not set _spec if an error is raised.#136
Merged
muhrin merged 2 commits intoaiidateam:developfrom Dec 12, 2019
Merged
Conversation
muhrin
requested changes
Dec 10, 2019
Collaborator
|
Just to keep you updated: I'm working on fixing the tests which seem to have broken because of a new version of PyYaml |
When an error is raised while building the spec of a process, the _spec attribute is deleted, and __called set to False. This ensures that subsequent calls to .spec() also raise the error instead of returning an incomplete spec.
greschd
force-pushed
the
fix_catch_errors_when_creating_spec
branch
from
721bc9e to
092f50e
Compare
muhrin
approved these changes
Dec 12, 2019
unkcpz
pushed a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
When an error is raised while building the spec of a process, the _spec attribute is deleted, and __called set to False. This ensures that subsequent calls to .spec() also raise the error instead of returning an incomplete spec.
agoscinski
pushed a commit
to agoscinski/plumpy
that referenced
this pull request
Apr 13, 2026
When an error is raised while building the spec of a process, the _spec attribute is deleted, and __called set to False. This ensures that subsequent calls to .spec() also raise the error instead of returning an incomplete spec.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
When an error is raised while building the spec of a process, the _spec attribute is deleted, and __called set to False. This ensures that subsequent calls to .spec() also raise the error instead of returning an incomplete spec.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
When an error is raised while building the spec of a process, the _spec attribute is deleted, and __called set to False. This ensures that subsequent calls to .spec() also raise the error instead of returning an incomplete spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error is raised while building the spec of a process, the
_specattribute is deleted, and__calledset toFalse. This ensures that subsequent calls to.spec()also raise the error instead of returning an incomplete spec.Related AiiDA issue and PR: aiidateam/aiida-core#3604, aiidateam/aiida-core#3617