Gsoc: drop six dependencies#151
Merged
sphuber merged 7 commits intoaiidateam:asynciofrom Apr 29, 2020
Merged
Conversation
sphuber
requested changes
Apr 28, 2020
Collaborator
sphuber
left a comment
sphuber
left a comment
There was a problem hiding this comment.
Thanks a lot @unkcpz . Just a few minor comments in your changes. Then there are a few additional things we can improve now that we are dropping Python 2 support:
- Remove useless object inheritance, i.e. change
class Sub(object):toclass Sub:. - Remove the corresponding pylint disable statements
# pylint: disable=useless-object-inheritance - Remove the
python-modernizehook from thepre-commit-config.yaml - Replace occurrences of
u'some string'to'some string', theuunicode indicator is no longer necessary - Get rid of
SavableFuture._tb_loggerand related functionality - Replace custom
utils.SimpleNamespacewith builtintypes.SimpleNamespace - Update
classifiersinsetup.py - Remove
'pylint<2; python_version<"3"'fromsetup.pyextra requires
Member
Author
|
Except for |
Member
Author
|
And I turn on pre-commit this time, so there are some code style fixes. |
sphuber
approved these changes
Apr 29, 2020
Collaborator
|
Thanks a lot @unkcpz ! Great first step. I will now first move from Travis to Github actions just like all our other projects and then we can continue with the rest of your changes |
unkcpz
added a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
* Remove six dependency * Remove Python 2.7 and add Python 3.8 to CI * Update Python supported versions `classifiers` in `setup.py` * Remove useless object inheritance and corresponding pylint disable statements * Remove the `python-modernize` hook from the `pre-commit-config.yaml` * Replace occurrences of `u'some string'` to `'some string'` * Get rid of `SavableFuture._tb_logger` and related functionality * Replace custom `utils.SimpleNamespace` with builtin `types.SimpleNamespace` * Remove `'pylint<2; python_version<"3"'` from `setup.py` extra requires
agoscinski
pushed a commit
to agoscinski/plumpy
that referenced
this pull request
Apr 13, 2026
* Remove six dependency * Remove Python 2.7 and add Python 3.8 to CI * Update Python supported versions `classifiers` in `setup.py` * Remove useless object inheritance and corresponding pylint disable statements * Remove the `python-modernize` hook from the `pre-commit-config.yaml` * Replace occurrences of `u'some string'` to `'some string'` * Get rid of `SavableFuture._tb_logger` and related functionality * Replace custom `utils.SimpleNamespace` with builtin `types.SimpleNamespace` * Remove `'pylint<2; python_version<"3"'` from `setup.py` extra requires
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
* Remove six dependency * Remove Python 2.7 and add Python 3.8 to CI * Update Python supported versions `classifiers` in `setup.py` * Remove useless object inheritance and corresponding pylint disable statements * Remove the `python-modernize` hook from the `pre-commit-config.yaml` * Replace occurrences of `u'some string'` to `'some string'` * Get rid of `SavableFuture._tb_logger` and related functionality * Replace custom `utils.SimpleNamespace` with builtin `types.SimpleNamespace` * Remove `'pylint<2; python_version<"3"'` from `setup.py` extra requires
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
* Remove six dependency * Remove Python 2.7 and add Python 3.8 to CI * Update Python supported versions `classifiers` in `setup.py` * Remove useless object inheritance and corresponding pylint disable statements * Remove the `python-modernize` hook from the `pre-commit-config.yaml` * Replace occurrences of `u'some string'` to `'some string'` * Get rid of `SavableFuture._tb_logger` and related functionality * Replace custom `utils.SimpleNamespace` with builtin `types.SimpleNamespace` * Remove `'pylint<2; python_version<"3"'` from `setup.py` extra requires
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sphuber
This PR
sixdependency andfrom __future__clause.I assume to bring pre-commit related modified task in the next parallel PR, so that all subsequent changes can have code style checks easily turned on.