Dependencies: relax requirement nest-asyncio~=1.5#229
Merged
Conversation
It was pinned to a patch version which was causing conflicts with other dependencies for `aiida-core`, notably `notebook`. We update instead of relaxing to the `1.4` minor version, because `v1.5` contains incompatible changes in the reset of the event loop policy.
Codecov Report
@@ Coverage Diff @@
## develop #229 +/- ##
===========================================
- Coverage 90.58% 90.56% -0.01%
===========================================
Files 22 22
Lines 2980 2974 -6
===========================================
- Hits 2699 2693 -6
Misses 281 281
Continue to review full report at Codecov.
|
sphuber
force-pushed
the
fix/update-nest-asyncio
branch
from
992eb26 to
ce0ba63
Compare
Collaborator
Author
Contributor
csadorf
approved these changes
Apr 8, 2022
sphuber
changed the title
nest-asyncio~=1.4nest-asyncio~=1.5
unkcpz
pushed a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
It was pinned to a patch version which was causing conflicts with other dependencies for `aiida-core`, notably `notebook`. We update instead of relaxing to the `1.4` minor version, because `v1.5` contains incompatible changes in the reset of the event loop policy.
agoscinski
pushed a commit
to agoscinski/plumpy
that referenced
this pull request
Apr 13, 2026
It was pinned to a patch version which was causing conflicts with other dependencies for `aiida-core`, notably `notebook`. We update instead of relaxing to the `1.4` minor version, because `v1.5` contains incompatible changes in the reset of the event loop policy.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
It was pinned to a patch version which was causing conflicts with other dependencies for `aiida-core`, notably `notebook`. We update instead of relaxing to the `1.4` minor version, because `v1.5` contains incompatible changes in the reset of the event loop policy.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
It was pinned to a patch version which was causing conflicts with other dependencies for `aiida-core`, notably `notebook`. We update instead of relaxing to the `1.4` minor version, because `v1.5` contains incompatible changes in the reset of the event loop policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pinned to a patch version which was causing conflicts with other
dependencies for
aiida-core, notablynotebook.