🔧 FIX auto_persist decorator typing#239
Merged
chrisjsewell merged 2 commits intoaiidateam:masterfrom Oct 12, 2022
Merged
Conversation
This is used in aiida-core, to decorate the `WorkChain` class. The problem currently is that, because of the decorator typing, no methods defined on subclasses of `Savable` are available for static analysers (like IDE auto-completions). This change ensures the output of the decorator is the same as the input.
Codecov ReportBase: 90.46% // Head: 90.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 90.46% 90.46% +0.01%
==========================================
Files 21 21
Lines 2953 2954 +1
==========================================
+ Hits 2671 2672 +1
Misses 282 282
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
Collaborator
How does this show that it is working? The |
sphuber
approved these changes
Oct 12, 2022
Member
Author
unkcpz
pushed a commit
to unkcpz/plumpy
that referenced
this pull request
Dec 14, 2024
This is used in aiida-core, to decorate the `WorkChain` class. The problem currently is that, because of the decorator typing, no methods defined on subclasses of `Savable` are available for static analysers (like IDE auto-completions). This change ensures the output of the decorator is the same as the input.
agoscinski
pushed a commit
to agoscinski/plumpy
that referenced
this pull request
Apr 13, 2026
This is used in aiida-core, to decorate the `WorkChain` class. The problem currently is that, because of the decorator typing, no methods defined on subclasses of `Savable` are available for static analysers (like IDE auto-completions). This change ensures the output of the decorator is the same as the input.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
This is used in aiida-core, to decorate the `WorkChain` class. The problem currently is that, because of the decorator typing, no methods defined on subclasses of `Savable` are available for static analysers (like IDE auto-completions). This change ensures the output of the decorator is the same as the input.
agoscinski
pushed a commit
that referenced
this pull request
Apr 13, 2026
This is used in aiida-core, to decorate the `WorkChain` class. The problem currently is that, because of the decorator typing, no methods defined on subclasses of `Savable` are available for static analysers (like IDE auto-completions). This change ensures the output of the decorator is the same as the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is used in aiida-core,
to decorate the
WorkChainclass.The problem currently is that, because of the decorator typing,
no methods defined on subclasses of
Savableare available for static analysers (such as IDE auto-completions).
This change ensures the output of the decorator is the same as the input.