Fix for #12 Native defaultdict for 2.5+ #42
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The following is the fix as per the suggestion in #12 which suggests
The collections.defaultdict class http://docs.python.org/library/collections.html#collections.defaultdict
could be used for Python 2.5+ rather than the method in utils.py
Solution:
The DefaultDict function implementation does the above and also maintains backward compatibility taking into account the fact that the native implementation in 2.5+ requires a callable for setting default values and the original implementation made use of non callables like 0 or []. The implementation allows using both a callable or the previous method.