Track the recommender's unified simulation module in the test mock list#184
Open
marota wants to merge 1 commit into
Open
Track the recommender's unified simulation module in the test mock list#184marota wants to merge 1 commit into
marota wants to merge 1 commit into
Conversation
…st mock list The expert_op4grid_recommender R4 refactor merged the grid2op/pypowsybl simulation helpers into a single backend-agnostic utils.simulation module and deleted utils.simulation_pypowsybl. Update the backend test conftest's mock-module list to reference utils.simulation so the mock layer stays accurate; no production Co-Study code imports either module, so the integration is otherwise unchanged (verified against the real recommender). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014npyG1CZHF5LxRL8sa39op Signed-off-by: Claude <noreply@anthropic.com>
marota
force-pushed
the
claude/config-simulation-refactor-182zzz
branch
from
2269496 to
6ee7e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the
expert_op4grid_recommenderR4 refactor (v0.2.8), which merged the grid2op / pypowsybl simulation helpers into a single backend-agnosticutils.simulationmodule and deletedutils.simulation_pypowsybl.Change
expert_backend/tests/conftest.py: update the domain-package mock list to referenceexpert_op4grid_recommender.utils.simulationinstead of the now-deletedutils.simulation_pypowsybl, keeping the mock layer accurate.Why it's safe
utils.superposition,utils.make_env_utils,environment*,models,pypowsybl_backend.simulation_env,config, and themainAPI are used), so the integration is otherwise unchanged.dotbinary) plus two golden-trace tests that fail identically on the pre-refactor recommender — i.e. pre-existing recommender/pypowsybl version drift, not caused by this change.configmodule stays plain and mutable), so Co-Study's directconfig.*mutations keep working.🤖 Generated with Claude Code
https://claude.ai/code/session_014npyG1CZHF5LxRL8sa39op