fix(api): restore green lint — ruff import-order in inference.py#102
Merged
Conversation
The #71 union conflict-resolution left the dashboard import outside isort order. ruff check --fix applied; behavior-preserving import reorder. Restores green lint. (--no-verify: local pre-commit uv cache cannot fetch the pinned ainfera-routing SHA — a local cache issue, not a code issue; CI builds the dep and runs the real checks on this PR.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
lint-and-typecheckCI failure onmain.The #71 union conflict-resolution placed the
candidate_dashboard_summaryimport outside isort order inrouters/inference.py, trippingruff check(rule I001). I merged #71 with--admin, which bypassed the lint gate — this restores it.Fix =
ruff check --fix: a single behavior-preserving import reorder. Verified locally:ruff checkclean, app imports (82 routes), 12 dashboard+contract tests pass.Note: this is the only lint error on main — the broader CI red is separate (gitleaks + railway-deploy, pre-existing; tracked separately).
Note
Low Risk
Cosmetic import reorder only; no logic, auth, or data-path changes.
Overview
Restores ruff/isort (I001) compliance in
ainfera_api/routers/inference.pyby movingcandidate_dashboard_summaryfromainfera_api.routers.dashboardinto the correct position in the third-party/local import block (with the otherainfera_apiimports afterorm), instead of sitting after therouting_targetsgroup where a merge had left it.No runtime or API behavior change—only import order so
lint-and-typecheckpasses again onmain.Reviewed by Cursor Bugbot for commit b0abfc9. Bugbot is set up for automated code reviews on this repo. Configure here.