feat(api): AIN-218 follow-up — provider on /v1/inferences/{id} + cell-coverage endpoint#57
Merged
Conversation
…icy_version, cell
Adds the four §16 fields the methodology v1.1 schema lock requires on
every routed inference.
· alembic 0022: additive columns on `inferences` (all nullable), two
Pg enums (inference_task_type, inference_task_type_source), partial
indexes on task_type + policy_version for the dashboard cell-coverage
gauge (AIN-210) and policy-drift telemetry.
· services/section16: pure helpers (policy_version, cell, resolve_task_type,
constraint_band) + v0 Anthropic-haiku classifier with 1.5s timeout and
best-effort fallback to "general" / source="default" on any failure.
· services/routing.dispatch_inference: resolve task_type (caller →
classifier → default), look up tenant's active routing policy,
populate all four fields on the InferenceORM row AND on the
inference.routed audit payload. Hash-chain invariant preserved:
old events keep their old payloads + hashes; new events carry the
richer payload and hash over it.
· routers/inference: accept optional task_type on InferenceRequest,
thread it through both the ainfera-auto and the direct dispatch
paths, expose the four fields on GET /v1/inferences/{id}.
Backfill: deferred (separate migration after Phase B Manwe traffic
produces enough rows). NOT NULL tightening also deferred.
Tests: 16 new unit tests cover policy_version determinism, ruleset_hash
drift detection, cell format, resolve_task_type precedence + enum
guard, classifier response parsing. 448/448 unit+smoke green.
Closes AIN-218 Phase 1 (code). DDL run is the next founder tap.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…empotency mock
The §16 classifier in services/section16.py calls api.anthropic.com/v1/messages —
the same URL the idempotency test mocks for the provider. The respx route matches
by URL only (not by model), so without an explicit task_type the classifier fires
on the first request and inflates call_count to 2.
Providing task_type="chat" in the request body routes resolve_task_type down the
source="caller" branch, skipping the classifier entirely. The test's intent
("provider hit once despite idempotent replay") is then accurately measured,
and we incidentally cover the §16 caller-supplied path.
Production code is unchanged. The classifier is already gated behind the
idempotency check in dispatch_inference, so idempotent replays never re-classify.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…verage endpoint
Two AIN-218 § follow-ups surfaced by the prod verification pass:
1. GET /v1/inferences/{id} returned provider=null because the code read it
from response_payload (the raw upstream body), which has no `provider`
key. The model row is already joined for `model.slug`; extend the join
to ProviderORM and surface `provider.slug` directly. The "no stealth
substitution" rule guarantees the routed model's provider answered, so
no extra reconciliation is needed.
2. New endpoint GET /v1/users/{handle}/cell-coverage — the AIN-210 KPI
surface. Aggregates distinct §16 cells observed across a handle's
agents and splits by Tier-1 (reasoning|code|extraction|chat) vs
Tier-2 (the rest). Pre-§16-migration rows are excluded via cell IS
NOT NULL — they're permanent gaps in the chain, not bugs to backfill.
Tests: empty-fleet zero-summary + mixed Tier-1/Tier-2 aggregation +
openapi contract allowlist update.
Closes the §16-render dependency for AIN-182 inference-detail + AIN-210
seed-readiness gauge.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AIN-218 [§16 P0] Outcome-capture schema migration — task_type + task_type_source + policy_version + cell
§16 schema LOCKED 2026-05-21 — one-shot immutable decisionThe audit chain is append-only + hash-chained → no backfill. Every routed call captured without these fields is a permanent gap. Manwe pipe is currently dead (zero traffic), so this is a lucky near-zero-loss window. Land this migration BEFORE the pipe is fixed and traffic resumes. Full spec: Methodology v1.1 §16 schema section Add to
|
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
…ULL)
The InferenceORM.request_payload column is NOT NULL by schema; the
direct-insert test path needs a non-null value. Use a minimal stub
({model, messages: []}) so the aggregation test exercises only the
cell-coverage logic and not unrelated payload validation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two AIN-218 §16 follow-ups surfaced during the prod verification pass after PR #56 merged:
Fix
providernull on inference detail.GET /v1/inferences/{id}was readingproviderfromresponse_payload(the raw upstream body, which never carries that key). The fix: joinProviderORMin the resolution query and surfaceprovider.slugdirectly. The "no stealth substitution" rule guarantees the routed model's provider answered, so no extra reconciliation logic is needed.Add
GET /v1/users/{handle}/cell-coverage— the AIN-210 KPI surface. Aggregates distinct §16 cells observed across the handle's agents and splits by Tier-1 (reasoning, code, extraction, chat) vs Tier-2 (the rest). Pre-§16-migration rows are excluded viacell IS NOT NULL— they're permanent gaps in the chain, not bugs to backfill. Returns summary counts + top 100 cells by frequency.Why now
provider: nullon a freshly-routed inference where the model + provider were both populated in the DB. Dashboard inference-detail page renders "—" for provider in consequence.Test plan
curl https://api.ainfera.ai/v1/users/hizrianraz/cell-coverage -H "Authorization: Bearer …"returns the expected shapeGET /v1/inferences/{id}on the Phase A verification inference idf0e31cd3-…now returnsprovider: "anthropic"(wasnull)🤖 Generated with Claude Code