fix: Using .cjs extension for CommonJS check script #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Payload apps have "type": "module" in package.json, which treats all .js files as ES modules. The dependency check script uses CommonJS (require), causing a ReferenceError at runtime. Changes: - Rename check-deps.js to check-deps.cjs - Update all references to use .cjs extension - Update tests to expect .cjs filename This fixes the "require is not defined in ES module scope" error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 64.59% 69.53% +4.94%
==========================================
Files 154 185 +31
Lines 6064 7294 +1230
==========================================
+ Hits 3917 5072 +1155
+ Misses 2064 2025 -39
- Partials 83 197 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payload apps have "type": "module" in package.json, which treats all .js files as ES modules. The dependency check script uses CommonJS (require), causing a ReferenceError at runtime.
Changes:
This fixes the "require is not defined in ES module scope" error.