fix: Ignore public_networking attribute to prevent droplet replacement

[ainsleyclark]

The DigitalOcean Terraform provider v2.69.0 introduced public_networking as a new ForceNew attribute on digitalocean_droplet. Since existing droplets were provisioned before this attribute existed in the schema, Terraform was planning a destroy/replace on every run. Adding it to ignore_changes prevents the forced replacement without affecting the actual droplet configuration.

https://claude.ai/code/session_01PLmFfETL9zcXNotjb5fVGK

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[claude]

Review summary

• Overall score: 9/10
• Critical issues: 0
• Warnings: 1
• Suggestions: 1
• Recommendation: ✅ Approve

Minimal, targeted fix for a provider compatibility break. The approach is idiomatic Terraform and correctly prevents unintended droplet replacement caused by the public_networking ForceNew attribute introduced in DigitalOcean provider v2.69.0.

Critical issues 🔴

None

Warnings 🟡

Silent drift on public_networking — Adding an attribute to ignore_changes means Terraform will never detect or apply future changes to it. If public_networking ever needs to be intentionally toggled, engineers must remember to temporarily remove it from ignore_changes and re-plan. This is a standard trade-off but worth noting in a code comment so the intent is not lost over time.

Suggestions 🟢

Add an inline comment explaining why public_networking is ignored, so future maintainers don't remove it thinking it's stale:

lifecycle {
  create_before_destroy = true
  ignore_changes = [
    user_data,
    # public_networking was added as a ForceNew attribute in DigitalOcean provider
    # v2.69.0. Ignoring it prevents unintended destroy/replace on existing droplets.
    public_networking,
  ]
}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.26%. Comparing base (7f6b060) to head (e37ee68).
⚠️ Report is 529 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   64.59%   70.26%   +5.67%     
==========================================
  Files         154      187      +33     
  Lines        6064     7439    +1375     
==========================================
+ Hits         3917     5227    +1310     
+ Misses       2064     2012      -52     
- Partials       83      200     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.