docs: add runnable AsyncDualMDNSResolver example#100
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 521 521
Branches 23 23
=========================================
Hits 521 521 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdraco
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
examples/dual.py, a runnable example that resolves a.localhost throughan aiohttp
ClientSessionusingAsyncDualMDNSResolver.Why
AsyncDualMDNSResolveris documented as a first-class option in the README,docs/api.rst, anddocs/index.rst, butexamples/only demonstrated theplain
AsyncMDNSResolver. The dual resolver is the one most useful in realdeployments (mDNS and unicast DNS concurrently, first success wins), yet
users had no copy-pasteable runnable form of it.
How
examples/run.pyso the two are directly comparable.async withresolver pattern (resolver isn't owned byTCPConnector),matching the convention swept in across all snippets by docs: use async context manager in examples and quick starts #92.
the README so the example is self-documenting.
Testing
python -m py_compile examples/dual.py(local env can't run pytest — no zeroconf).purely additive.
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 34 insertions(+)
Code scan: 1 issue(s) found
examples/dual.py:28— debug print statementTests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline