feat: AIP-210 – Unicode#28
Merged
lukesneeringer merged 20 commits intomainfrom May 11, 2021
Merged
Conversation
mkistler
approved these changes
Mar 1, 2021
mkistler
left a comment
mkistler
left a comment
There was a problem hiding this comment.
Character encodings hurt my head.
I highlighted one sentence that I think doesn't fit in the generic AIPs, but could not find anything else that I felt qualified to question.
I'll approve on the assumption that we'll work out how to handle the troublesome sentence.
gibson042
reviewed
Mar 8, 2021
mkistler
approved these changes
May 8, 2021
mkistler
left a comment
mkistler
left a comment
There was a problem hiding this comment.
Looks good. 👍
I made a few suggestions on wording that you are free to accept or ignore as you see fit.
Co-authored-by: Mike Kistler <mkistler@us.ibm.com>
Co-authored-by: Mike Kistler <mkistler@us.ibm.com>
Co-authored-by: Mike Kistler <mkistler@us.ibm.com>
gibson042
reviewed
May 11, 2021
| (`[a-zA-Z][a-zA-Z0-9_-]*`). This ensures that there are never accidental | ||
| collisions due to normalization. If an API decides to allow all valid Unicode | ||
| characters in unique identifiers, the API **must** reject any inputs that are | ||
| not in Normalization Form C. |
Contributor
There was a problem hiding this comment.
Suggested change
| not in Normalization Form C. | |
| not in Normalization Form C and **should** follow | |
| [UAX #31](https://www.unicode.org/reports/tr31/), | |
| tailoring the Default Identifier Syntax as necessary to include additional | |
| Start, Medial, and Continue characters and documenting such adjustments. |
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.