[feat] Remove the state column, replace with a badge.#244
Merged
Conversation
This PR removes the "state" column from the general AIP index and replaces it with a "Reviewing" or "Draft" badge for AIPs in those states (and removes other states from the list entirely). This change only affects the "general" page to avoid needing everyone from every team to approve. After this is merged, I will send individual PRs to each team to migrate their indexes.
googlebot
added
the
cla: yes
Contributor
Author
|
|
jgeewax
reviewed
Aug 14, 2019
| {%- for p in site.pages %} | ||
| <!-- prettier-ignore --> | ||
| {%- if p.aip and p.aip.id >= include.start and p.aip.id <= include.end and | ||
| 'approved,reviewing,draft' contains p.aip.state %} |
Contributor
There was a problem hiding this comment.
We don't have an in operator ?
Contributor
Author
There was a problem hiding this comment.
Nope. Liquid is silly that way.
| {% endfor %} | ||
|
|
||
| <!-- prettier-ignore-end --> | ||
| {% include aip-listing.html start=100 end=119 %} |
Contributor
There was a problem hiding this comment.
Are the start/end parameters doing something specific? Can we comment this ?
Contributor
Author
There was a problem hiding this comment.
Yes, they tell the included file which AIPs to render. So this means that the table will include any AIPs between 100 and 119, inclusive.
(This used to be hard-coded in the Markdown.)
Contributor
Author
There was a problem hiding this comment.
I added a comment in the included file.
jgeewax
approved these changes
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the "state" column from the general AIP index and replaces it with a "Reviewing" or "Draft" badge for AIPs in those states (and removes other states from the list entirely).
This change only affects the "general" page to avoid needing everyone from every team to approve.
After this is merged, I will send individual PRs to each team to migrate their indexes.