Use shellescape on paths in run_diff #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Neovim 0.11.1 within MSYS2 on Windows, gitgutter wasn't showing up. After some flailing around, I found adding `set shellcmdflag=-c shellxquote= shellxescape=` [from here](neovim/neovim#28384 (comment)), got `:echo system('git --version')` working. The signs were still not showing up, but there were files being dumped in my current working directory that looked like corrupted Windows paths. After using `let g:gitgutter_log=1` and looking at the log I found where these temp files were made and I think I fixed it. I haven't tried the non-msys2 Neovim (assuming that's different) or normal vim, but I brought the change over and made sure it worked in Neovim on Linux.
iguessthislldo
force-pushed
the
igtd/windows
branch
from
b72fece to
7e47271
Compare
Contributor
Author
|
Force pushed to fix the URL to the Neovim issue. |
Owner
|
Thanks for reporting this. I don't use Windows so (a) I don't know if something doesn't work there, and (b) I can't tell when it is fixed. So thank you for taking the time to figure out an answer. The whole running-things-in-a-shell-on-Windows thing has always been a nightmare. Your patch makes sense and in fact I'm not sure why I didn't write it that way to start with. The tests all pass so I'll merge this. |
Contributor
Author
I agree. If I wasn't temporarily forced to use MSYS2 instead of WSL or normal Linux, I wouldn't bother trying to get this working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Neovim 0.11.1 within MSYS2 on Windows, gitgutter wasn't showing up. After some flailing around, I found adding
set shellcmdflag=-c shellxquote= shellxescape=from here, got:echo system('git --version')working. The signs were still not showing up, but there were files being dumped in my current working directory that looked like corrupted Windows paths.After using
let g:gitgutter_log=1and looking at the log I found where these temp files were made and I think I fixed it. I haven't tried the non-msys2 Neovim (assuming that's different) or normal vim, but I brought the change over and made sure it worked in Neovim on Linux.