Skip to content

Conversation

@austinbyers
Copy link
Collaborator

Upgrades to Terraform v0.10! This lets us upgrade to the latest AWS provider and supports interactive approval during each apply operation.

No work is required for users to upgrade as long as the latest terraform binary is in their PATH.

During a deploy, the user is now required to explicitly approve the changes for the main apply. However, the second apply (which only updates Lambda aliases) happens automatically, because it shouldn't even be necessary. If the Lambda function updates (and the user approves), then its alias will have to update as well. It would also be annoying for the user to have to explicitly approve twice on every deploy.

Resolves: #32 (Terraform v0.10)
Required for: #6 (Cloudwatch dashboard)

Tested

Tested with a deploy and live_test. A deploy now looks like this:

$ python3 manage.py deploy
...
Do you want to apply these changes?
  Terraform will apply the changes described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes
...

Reviewers

to: @jacknagz
cc: @airbnb/binaryalert-maintainers

@austinbyers austinbyers requested a review from jacknagz August 29, 2017 05:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.508% when pulling fefa161 on abb--terraform-0-10-2 into 6134b33 on master.

@austinbyers austinbyers modified the milestone: 1.0.0 Aug 29, 2017
Copy link
Contributor

@jacknagz jacknagz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do users have to run terraform init to get the new provider?

@austinbyers
Copy link
Collaborator Author

@jacknagz , yes terraform init is required to get the provider, but BinaryAlert runs that automatically on every deploy anyway

Copy link
Contributor

@jacknagz jacknagz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@austinbyers sounds good, just wanted to verify

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.548% when pulling 6cb7d69 on abb--terraform-0-10-2 into 2ef588b on master.

@austinbyers austinbyers merged commit e98d780 into master Aug 30, 2017
@austinbyers austinbyers deleted the abb--terraform-0-10-2 branch August 30, 2017 20:41
austinbyers added a commit that referenced this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants