Upgrade to Terraform v0.10 #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to Terraform v0.10! This lets us upgrade to the latest AWS provider and supports interactive approval during each
applyoperation.No work is required for users to upgrade as long as the latest
terraformbinary is in their PATH.During a deploy, the user is now required to explicitly approve the changes for the main
apply. However, the secondapply(which only updates Lambda aliases) happens automatically, because it shouldn't even be necessary. If the Lambda function updates (and the user approves), then its alias will have to update as well. It would also be annoying for the user to have to explicitly approve twice on every deploy.Resolves: #32 (Terraform v0.10)
Required for: #6 (Cloudwatch dashboard)
Tested
Tested with a deploy and
live_test. A deploy now looks like this:Reviewers
to: @jacknagz
cc: @airbnb/binaryalert-maintainers