How to address consistent-return & array-callback-return with condition

[gplusdotgr]

How should I properly address the following:

const things = [
  {
    toy: 'lego',
  },
  {
    ball: 'football',
  },
  {
    series: 'spongebob',
  },
]

const newThings = things.map((item) => {
  if (item.toy) {
    return item.toy.toUpperCase();
  }
}).filter((n) => n);

// eslint error for consistent-return & array-callback-return

[alfredosalzillo]

Function and Arrow with at least one return should always return. In your case, if item.toy is falsy you return nothing.

const newThings = things.map((item) => {
  if (item.toy) {
    return item.toy.toUpperCase();
  }
 return null;
}).filter((n) => n);

[gplusdotgr]

I figured inverting the methods solves my issue:

const newThings = things
  .filter((n) => n)
  .map((item) => item.toy.toUpperCase());

[ljharb]

Also, .filter(Boolean).